Updating docker files to support Inivation's DVXplorer Micro camera#17
Conversation
There was a problem hiding this comment.
Thank you for the suggestion.
If you add a support for Inivation's DVXploere Micro camera, we should create another Dockerfile only for this camera to simplify docker environments.
In addition, you added some changes for WSL system, which contaminate the environment. Important thing to manage Github repository is to simplify the environment. So, I recommend you to revert these modifications.
| @@ -1,19 +1,24 @@ | |||
| services: | |||
| edopt: | |||
| testedopt: | |||
There was a problem hiding this comment.
We don't need to change service name.
| environment: | ||
| - DISPLAY=unix$DISPLAY | ||
| - /tmp/.X11-unix:/tmp/.X11-unix | ||
| - /usr/lib/wsl:/usr/lib/wsl |
There was a problem hiding this comment.
This part is also for WSL. Could you delete it not to contaminate the docker environment?
| devices: | ||
| - /dev/dxg:/dev/dxg |
There was a problem hiding this comment.
This part is also for WSL, so could you please delete it?
| stdin_open: true | ||
| tty: true No newline at end of file |
There was a problem hiding this comment.
If you just want to go inside docker container, you just do docker exec -it edopt /bin/bash.
Therefore, this modification is not required.
So, could you revert this part?
|
Hi @mikihiroikura, I apologize for the delay. I have made the required changes and everything should be good with the latest version. Thanks! |
|
@jorou125 Sorry to be late for the reponse. I will merge it, and then I would like to polish the code a little bit. |
mikihiroikura
left a comment
mikihiroikura
left a comment
There was a problem hiding this comment.
I approved, but I will modify these parts
| ENV LD_LIBRARY_PATH=/usr/lib/wsl/lib | ||
| ENV LIBVA_DRIVER_NAME=d3d12 |
There was a problem hiding this comment.
I'm going to delete this part because it is for WSL, right?
| git clone https://github.com/jorou125/DV-EDOPT.git &&\ | ||
| mv DV-EDOPT EDOPT &&\ | ||
| cd EDOPT &&\ |
There was a problem hiding this comment.
Currently, you used your forked repository. After merging your request, I will switch to our github repository
2 participants
Updated versions of the docker and docker-compose file to allow interaction with
dv-bridge-sdkand use of GPU ressources. These are the modifications I used to develop and test thedv-bridge-sdk, as discussed with @arrenglover . Have a good day!