-
Couldn't load subscription status.
- Fork 4
Dependency inversion #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello erhankur, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
a35e5f7 to
e4c17cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e4c17cf to
dfc804e
Compare
|
LGTM, thanks, left one comment. This is what I had in mind, we can also limit some supported functions by using target capabilities without adding circular dependency now IIUC, still would like to avoid ifdefs, but it is possible. |
|
This structure looks good! Sorry for nit-picking, just to get better README. Which the three layers do you mean? I found lists with 4 items. |
afff630 to
709ef1e
Compare
Base is not a physical layer. Interface for common and target. Readme is updated to clarify private folder purpose. |
|
Thanks everyone for reviews. |
Dependency inverted as common to target. Now flow will be like this:
Common code can now use target specific headers like <soc/soc.h> to implement generic functions once instead of duplicating across 13+ targets