-
Notifications
You must be signed in to change notification settings - Fork 3
Feat: Add uart support #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This commit adds support for UART with interrupt possibility and helper functions especially for RX path
👋 Hello Dzarda7, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
@antmak @erhankur WDYT? I implemented only the stuff we need, feel free to suggest changes or request other features. Few things that came to my mind during this:
Thanks! |
Thanks, yes, that is exactly what I meant. We might want to adapt the runtime approach for some functions too I believe, for example large vs normal flashing, but there might be simpler solution for that, we will see.
Yes, the issue is that I have no role in this repo. Thanks for letting me know. |
In view of #32 some points become clearer
I'm not aware many details, but I'd take newer chips into account, as their implementation is usually more mature. So looks good to implement things in
If it is not a stub-lib interface, then it makes sense |
Description
This PR adds support for UART and makes
soc_utils.h
part of public API as we need it in esp-flasher-stub.Testing
Tested with esp-flasher-stub. Receive in interrupt and response works.
Checklist
Before submitting a Pull Request, please ensure the following: