Skip to content

fix(omnivoice): silence -Werror=double-promotion in voice classifiers #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lalalune merged 1 commit into from
Jun 22, 2026
Merged

fix(omnivoice): silence -Werror=double-promotion in voice classifiers #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/omnivoice/src/voice-classifiers/voice_classifier/voice_diarizer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,11 @@ static void inst_norm_1d_inplace(float *buf, int C, int L,
for (int c = 0; c < C; ++c) {
float *row = buf + (size_t)c * L;
double sum = 0.0, sq = 0.0;
for (int i = 0; i < L; ++i) sum += row[i];
for (int i = 0; i < L; ++i) sum += (double)row[i];
const float mean = (float)(sum / L);
for (int i = 0; i < L; ++i) {
const float d = row[i] - mean;
sq += (double)d * d;
sq += (double)d * (double)d;
}
const float var = (float)(sq / L);
const float invstd = 1.0f / sqrtf(var + eps);
Expand Down
6 changes: 3 additions & 3 deletions tools/omnivoice/src/voice-classifiers/voice_classifier/voice_speaker.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ static int spk_compute_fbank(const struct voice_speaker_session *s,

/* DC offset removal. */
double dc = 0.0;
for (int i = 0; i < SPK_WINDOW_LEN; ++i) dc += frame[i];
for (int i = 0; i < SPK_WINDOW_LEN; ++i) dc += (double)frame[i];
dc /= (double)SPK_WINDOW_LEN;
for (int i = 0; i < SPK_WINDOW_LEN; ++i) frame[i] -= (float)dc;

Expand Down Expand Up @@ -370,7 +370,7 @@ static int spk_compute_fbank(const struct voice_speaker_session *s,
/* Per-utterance CMN. */
for (int m = 0; m < SPK_N_MELS; ++m) {
double mean = 0.0;
for (int t = 0; t < frames; ++t) mean += feats_out[t * SPK_N_MELS + m];
for (int t = 0; t < frames; ++t) mean += (double)feats_out[t * SPK_N_MELS + m];
mean /= (double)frames;
for (int t = 0; t < frames; ++t) feats_out[t * SPK_N_MELS + m] -= (float)mean;
}
Expand Down Expand Up @@ -572,7 +572,7 @@ int voice_speaker_embed(voice_speaker_handle h,
for (int oh = 0; oh < 10; ++oh) {
const float *slot = cur + ((size_t)oc * 10 + oh) * T_pool;
double mean = 0.0;
for (int t = 0; t < T_pool; ++t) mean += slot[t];
for (int t = 0; t < T_pool; ++t) mean += (double)slot[t];
mean /= (double)T_pool;
double var = 0.0;
for (int t = 0; t < T_pool; ++t) {
Expand Down
Loading