fix(omnivoice): silence -Werror=double-promotion in voice classifiers - #26
Merged
Conversation
The ubuntu-24-llguidance CI job builds the fused omnivoice tool with -DLLAMA_FATAL_WARNINGS=ON, which turns -Wdouble-promotion into an error. Five intentional float→double accumulations in the scalar voice-classifier forwards (voice_speaker.c DC-removal, mel mean-centering, TDNN stats-pool mean; voice_diarizer.c instance-norm mean/var) promoted a float operand implicitly. Make each promotion explicit with a (double) cast — identical numerics, no more warning. The sibling conv/linear accumulators are float and correctly untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ubuntu-24-llguidanceCI job builds the fused omnivoice tool with-DLLAMA_FATAL_WARNINGS=ON, turning-Wdouble-promotioninto a hard error. Five intentional float→double accumulations in the scalar voice-classifier forwards promoted a float operand implicitly:voice_speaker.c: DC-offset removal (338), mel mean-centering (373), TDNN stats-pool mean (575)voice_diarizer.c: instance-norm mean (117) and variance (121)Each is made explicit with a
(double)cast — identical numerics, warning gone. The sibling conv/linear+=accumulators are float (no promotion) and are correctly left untouched.🤖 Generated with Claude Code