Skip to content

Remove special logic for unassigned shards from WriteLoadConstraintDecider #136793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove special logic for unassigned shards from WriteLoadConstraintDecider #136793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfc546e
Remove special logic for unassigned shards from WriteLoadConstraintDe…
nicktindall Oct 20, 2025
979b859
Merge branch 'main' into remove_special_case_for_unassigned
nicktindall Oct 20, 2025
5592a94
Merge branch 'main' into remove_special_case_for_unassigned
nicktindall Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...java/org/elasticsearch/cluster/routing/allocation/decider/WriteLoadConstraintDecider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,6 @@ public Decision canAllocate(ShardRouting shardRouting, RoutingNode node, Routing
return Decision.single(Decision.Type.YES, NAME, "Decider is disabled");
}

// Never reject allocation of an unassigned shard
if (shardRouting.assignedToNode() == false) {
return Decision.single(Decision.Type.YES, NAME, "Shard is unassigned. Decider takes no action.");
}

// Check whether the shard being relocated has any write load estimate. If it does not, then this decider has no opinion.
var allShardWriteLoads = allocation.clusterInfo().getShardWriteLoads();
var shardWriteLoad = allShardWriteLoads.get(shardRouting.shardId());
Expand Down
10 changes: 0 additions & 10 deletions ...org/elasticsearch/cluster/routing/allocation/decider/WriteLoadConstraintDeciderTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,16 +126,6 @@ public void testWriteLoadDeciderCanAllocate() {
"Node [*] with write thread pool utilization [0.99] already exceeds the high utilization threshold of [0.900000]. "
+ "Cannot allocate shard [[test-index][1]] to node without risking increased write latencies."
);
assertDecisionMatches(
"Unassigned shard should always be accepted",
writeLoadDecider.canAllocate(
testHarness.unassignedShardRouting,
randomFrom(testHarness.exceedingThresholdRoutingNode, testHarness.belowThresholdRoutingNode),
testHarness.routingAllocation
),
Decision.Type.YES,
"Shard is unassigned. Decider takes no action."
);
assertDecisionMatches(
"Assigning a new shard to a node that has capacity should succeed",
writeLoadDecider.canAllocate(
Expand Down