Remove special logic for unassigned shards from WriteLoadConstraintDecider #136793
+0
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktindall
added
>non-issue
:Distributed Coordination/Allocation
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
|
Do we know whether the Reconciler is OK with this change, i.e. it will not leave shard unassigned if the only option is |
Actually good point, it is not. I will open a ticket to get that done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was special handling for unassigned shards in
WriteLoadConstraintDecider#canAllocate, this is handled generally in #136733, so is no longer necessary in the decider once we merge that.The new approach is actually superior because it will prioritise allocation of unassigned shards to nodes that return
YESover nodes that returnNOT_PREFERRED. Although it probably makes no difference for the write load decider, because the write load decider won't intervene if we have no shard write load, which is probably most often the case for an unassigned shard.Depends on #136733