log: C++-based backend implementation #14

arkjedrz · 2025-12-29T13:52:39Z

mw_log backend implementation using baselibs.

github-actions · 2025-12-29T13:57:11Z

The created documentation from the pull request is available at: docu-html

github-actions · 2026-01-06T09:18:40Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 8cc46ddc-7f90-462f-9447-7685a2c0e754
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-eQOopREOYCL5vtTb6c1cwZrql4GVrJ1FqgxarQRe1xs="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'bazel_skylib', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 13.033s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

arkjedrz · 2026-01-19T09:09:44Z

Source code is ready, renames to be done.

pawelrutkaq · 2026-01-07T09:26:00Z

src/rust/mw_logger/examples/main.rs

+
+    trace!("This is a trace log - hidden");
+    debug!("This is a debug log - hidden");
+    error!("This is an error log");


missing usage with constext on default logger

pawelrutkaq · 2026-01-07T09:28:11Z

score/mw/log/rust/score_log_bridge/src/adapter.cpp

+        if (logger->IsLogEnabled(current)) {
+            return current;
+        }
+    }


@hoppe-and-dreams dont we have some API to just check it instead of manually resolving it ?

@rmaddikery ?

MODULE.bazel

pawelrutkaq · 2026-01-20T07:30:50Z

score/mw/log/rust/score_log_bridge/src/ffi.rs

+        // Copy data into array.
+        let mut data: [c_char; 4] = [0; 4];
+        unsafe {
+            core::ptr::copy_nonoverlapping(context.as_ptr(), data.as_mut_ptr() as *mut u8, size);


cast<>() instead as

pawelrutkaq · 2026-01-20T07:31:50Z

score/mw/log/rust/score_log_bridge/src/ffi.rs

+
+impl Recorder {
+    pub fn new() -> Self {
+        let inner = unsafe { recorder_get() };


caling C FFi shall do ptr checking. So check nullptrs ie with debug_assert

Can do, but why debug_assert and not assert?

pawelrutkaq · 2026-01-20T07:41:08Z

score/mw/log/rust/score_log_bridge/src/score_logger.rs

+                if let Some(ref path) = self.config_path {
+                    let path_os_str = path.as_os_str();
+                    if !path_os_str.is_empty() {
+                        unsafe { set_var(KEY, path_os_str) };


add #safety caluse to all unsafe stuff in this pr

pawelrutkaq · 2026-01-20T07:42:44Z

score/mw/log/rust/score_log_bridge/src/score_logger.rs

+        // Create log stream.
+        let context = metadata.context();
+        let log_level = metadata.level().into();
+        let log_stream = LogStream::new(&self.recorder, context, log_level);


as writen before, if internals of this failed, we can jsut skip logging here.

pawelrutkaq · 2026-01-20T07:43:28Z

score/mw/log/rust/score_log_bridge/src/score_logger.rs

+}
+
+// SAFETY: The underlying C++ logger is known to be thread-safe.
+unsafe impl Send for ScoreLogger {}


The C++ ffi types shall have sync/send markups

pawelrutkaq · 2026-01-20T07:44:33Z

score/mw/log/rust/score_log_bridge/src/score_logger_writer.rs

+/// [`score_log::fmt::ScoreWrite`] writer implementation used by [`crate::ScoreLogger`].
+/// Adds values to the log stream with selected formatting.
+pub(crate) struct ScoreLoggerWriter<'a> {
+    log_stream: LogStream<'a>,


btw why not implement ScoreWrite over LogStream and doing next class here ?

pawelrutkaq · 2026-01-20T07:45:58Z

score/mw/log/rust/score_log_bridge/src/ffi.rs

+        Self { recorder, slot }
+    }
+
+    pub fn log_bool(&mut self, v: &bool) {


all those with inline hint.

`mw_log` backend implementation using `baselibs`.

- Improve `Context`: - Use it consistenly internally - no allocs. - Make use of `From` traits (to and from `&str`). - Check layout on every logger builder. - Cheap and rare operation, no deps to `std::sync` required. - Improve docs and add safety notes. - `LogMessage`: - Merge `ScoreLoggerWriter` and `LogStream` - less layers. - Remove `score_logger_writer.rs`. - Add `#[inline]` where applicable. - Prevent operation in erroneous state (e.g., when null returned). - Less branching. - Move `Send` and `Sync` where actually needed (to `Recorder`). - Improve example.

arkjedrz force-pushed the arkjedrz_mw-log branch from 34f6f12 to 235d8c1 Compare December 30, 2025 10:28

arkjedrz requested a review from vinodreddy-g January 5, 2026 09:18

arkjedrz force-pushed the arkjedrz_mw-log branch 2 times, most recently from 93febff to 8ff01eb Compare January 6, 2026 09:17

arkjedrz had a problem deploying to workflow-approval January 6, 2026 09:18 — with GitHub Actions Failure

arkjedrz force-pushed the arkjedrz_mw-log branch from 8ff01eb to a7e0958 Compare January 6, 2026 13:43

arkjedrz temporarily deployed to workflow-approval January 6, 2026 13:43 — with GitHub Actions Inactive

arkjedrz marked this pull request as ready for review January 6, 2026 13:53

arkjedrz requested review from antonkri, arsibo and pawelrutkaq as code owners January 6, 2026 13:53

arkjedrz force-pushed the arkjedrz_mw-log branch from a7e0958 to 50fc165 Compare January 7, 2026 10:09

arkjedrz temporarily deployed to workflow-approval January 7, 2026 10:09 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_mw-log branch from 50fc165 to cd7528c Compare January 7, 2026 13:41

arkjedrz temporarily deployed to workflow-approval January 7, 2026 13:41 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_mw-log branch from cd7528c to 872b1af Compare January 12, 2026 13:14

arkjedrz temporarily deployed to workflow-approval January 12, 2026 13:14 — with GitHub Actions Inactive

arkjedrz self-assigned this Jan 14, 2026

arkjedrz marked this pull request as draft January 15, 2026 07:28

arkjedrz temporarily deployed to workflow-approval January 16, 2026 13:25 — with GitHub Actions Inactive

arkjedrz temporarily deployed to workflow-approval January 19, 2026 08:25 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_mw-log branch from b2792db to dde419b Compare January 19, 2026 08:58

arkjedrz had a problem deploying to workflow-approval January 19, 2026 08:58 — with GitHub Actions Failure

arkjedrz force-pushed the arkjedrz_mw-log branch from dde419b to 018f7f5 Compare January 19, 2026 09:03

arkjedrz had a problem deploying to workflow-approval January 19, 2026 09:03 — with GitHub Actions Failure

arkjedrz force-pushed the arkjedrz_mw-log branch from 018f7f5 to 8b22ae1 Compare January 19, 2026 09:05

arkjedrz had a problem deploying to workflow-approval January 19, 2026 09:05 — with GitHub Actions Failure

arkjedrz marked this pull request as ready for review January 19, 2026 09:07

arkjedrz requested a review from rmaddikery January 19, 2026 09:07

arkjedrz force-pushed the arkjedrz_mw-log branch from 8b22ae1 to c1ab28e Compare January 19, 2026 11:02

arkjedrz had a problem deploying to workflow-approval January 19, 2026 11:03 — with GitHub Actions Failure

arkjedrz force-pushed the arkjedrz_mw-log branch from c1ab28e to 7f41f28 Compare January 19, 2026 11:41

arkjedrz had a problem deploying to workflow-approval January 19, 2026 11:41 — with GitHub Actions Failure

arkjedrz force-pushed the arkjedrz_mw-log branch from 7f41f28 to b950507 Compare January 19, 2026 15:38

arkjedrz temporarily deployed to workflow-approval January 19, 2026 15:38 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_mw-log branch from b950507 to 28050b6 Compare January 20, 2026 07:24

arkjedrz temporarily deployed to workflow-approval January 20, 2026 07:25 — with GitHub Actions Inactive

pawelrutkaq requested changes Jan 20, 2026

View reviewed changes

pawelrutkaq mentioned this pull request Jan 20, 2026

Updates CODEOWNERS for datarouter and mw/log directories #29

Open

10 tasks

arkjedrz temporarily deployed to workflow-approval January 21, 2026 09:54 — with GitHub Actions Inactive

arkjedrz added 2 commits January 21, 2026 09:55

log: C++-based backend implementation

32f710e

`mw_log` backend implementation using `baselibs`.

arkjedrz force-pushed the arkjedrz_mw-log branch from 2e20e41 to 7e0c59d Compare January 21, 2026 09:55

arkjedrz temporarily deployed to workflow-approval January 21, 2026 09:56 — with GitHub Actions Inactive

arkjedrz requested a review from pawelrutkaq January 21, 2026 09:56

log: C++-based backend implementation #14

Are you sure you want to change the base?

log: C++-based backend implementation #14

Conversation

arkjedrz commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

github-actions bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

arkjedrz commented Jan 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

arkjedrz commented Dec 29, 2025 •

edited

Loading

github-actions bot commented Jan 6, 2026 •

edited

Loading