-
Notifications
You must be signed in to change notification settings - Fork 9
Updates CODEOWNERS for datarouter and mw/log directories #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
d9fea1a to
87d8389
Compare
.github/CODEOWNERS
Outdated
| score/mw/log/BUILD @rmaddikery @hoppe-and-dreams @mobileinfo @andreapefe @RSingh1511 @Y-Vaishnavi | ||
|
|
||
| # mw/log rust mw_logger owners | ||
| score/mw/log/rust/mw_logger @pawelrutkaq @arkjedrz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please align to folder names in #14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, align with folder that is not in main? Can't that be updated when that PR is brought in?
| # default owners | ||
| * @antonkri @rmaddikery @hoppe-and-dreams @mobileinfo @andreapefe @RSingh1511 @Y-Vaishnavi @pawelrutkaq @arkjedrz @arsibo | ||
| * @antonkri @pawelrutkaq @arkjedrz @arsibo | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of this is probable as simple as
# Datarouter owners
/score/datarouter/ @rmaddikery @hoppe-and-dreams @mobileinfo @andreapefe @RSingh1511 @Y-Vaishnavi
# mw/log owners - all paths except rust/mw_logger
/score/mw/log/ @rmaddikery @hoppe-and-dreams @mobileinfo @andreapefe @RSingh1511 @Y-Vaishnavi
# mw/log rust mw_logger owners (more specific rule overrides general rule above)
/score/mw/log/rust/mw_logger/ @pawelrutkaq @arkjedrz
isnt it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that's fine too. I am a fan of being explicit, but with a comment like you suggested should suffice. Thanks
87d8389 to
ecf1f62
Compare
ecf1f62 to
ca3faa7
Compare
- Assign codeowners to directories based on initial contributions
ca3faa7 to
d0dda45
Compare
FScholPer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still errors in the file
Unknown owner on line 2: make sure @arkjedrz exists and has write access to the repository
Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #