Skip to content

docs(migrate): match the Playwright mapping to what e2e does - #1545

Merged
okwasniewski merged 3 commits into
mainfrom
oskar/playwright-migrate-docs-2
Nov 4, 2026
Merged

okwasniewski merged 3 commits into
mainfrom
oskar/playwright-migrate-docs-2

Conversation

@okwasniewski

@okwasniewski okwasniewski commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

What and why

docs/migrate/playwright.mdx claimed parity in rows that the ported Playwright tests in apps/testbed/tests (#1505) disprove or leave out. Each row below now matches main, checked against the source and the tests' fail/skip marks and "Not ported" headers.

  • Runner and CLI rows (workers, retries, trace, video, hooks, test.skip, test.setTimeout, test.use, CLI flags, -u) go from same to renamed/missing and name their limits.
  • test.fail() is now same. The row notes that members of a serial group and setup tests can't be marked (keeps main's feat(e2e): test.fail for tests expected to fail #1539 row).
  • inputValue() on an element that isn't an input reads "", where Playwright throws (packages/e2e/src/locator/screen.ts:562).
  • uncheck() on a checked radio, role=radio included, is NOT_ACTIONABLE (packages/web/src/actions.ts:59).
  • The 1 s hold of a negated matcher is capped by its timeout.
  • ? in a browser.route glob matches one character, where Playwright reads it literally.
  • route.fulfill bodies are strings only, and each header takes one value, so one set-cookie. A route.continue header can't be deleted (packages/web/src/route-options.ts).
  • { timeout: 0 }: INVALID_ARGUMENT on waitForResponse, waitForDownload, and toHaveScreenshot. Any other call times out at once.
  • An element inside a visibility: hidden iframe reads as visible.
  • goto('data:') is now by design. A new "What differs on purpose" bullet states the navigation rule: http, https, and about:blank only (packages/e2e/src/internal/urls.ts:137). That bullet replaces the undefined "navigation rule" reference.
  • No about:blank page before the first goto.
  • browser.evaluate and locator reads run in the page's main world.

Rows describe how main behaves today. Open PRs that close gaps (clearing file inputs, binary bodies, header deletion, several set-cookie, hidden iframes, isolated world) update their own rows.

Verified

Ran it locally: yes

  • pnpm docs:check: 70 pages compile as MDX, and 1018 anchors resolve.
  • A fresh-context reviewer checked every changed row against packages/*/src and the testbed marks. It found two false claims, both now fixed: test.skip in afterEach, and timeout: 0 on every browser call.

Checklist

  • Changeset added (pnpm changeset) for any change to a published package, or the change is testbed, docs, or CI only.
  • Docs updated in the same PR.

@github-actions github-actions Bot added the size:M Up to 99 changed lines, not counting tests, fixtures, or the lockfile label Nov 4, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread docs/migrate/playwright.mdx Resolved
Comment thread docs/migrate/playwright.mdx Resolved
@okwasniewski
okwasniewski merged commit 0852e61 into main Nov 4, 2026
30 checks passed
@okwasniewski
okwasniewski deleted the oskar/playwright-migrate-docs-2 branch November 4, 2026 18:38
kblok added a commit to hardkoded/e2e-dotnet that referenced this pull request Nov 4, 2026
* Match the Playwright migration mapping to what e2e does (e2e-inc/e2e#1545)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK

* Correct the InputValueAsync, .Not, and timeout rows

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready for Human Review size:M Up to 99 changed lines, not counting tests, fixtures, or the lockfile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant