Repository navigation
docs(migrate): match the Playwright mapping to what e2e does - #1545
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
kblok
added a commit
to hardkoded/e2e-dotnet
that referenced
this pull request
Nov 4, 2026
* Match the Playwright migration mapping to what e2e does (e2e-inc/e2e#1545) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK * Correct the InputValueAsync, .Not, and timeout rows Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
docs/migrate/playwright.mdxclaimed parity in rows that the ported Playwright tests inapps/testbed/tests(#1505) disprove or leave out. Each row below now matches main, checked against the source and the tests'fail/skipmarks and "Not ported" headers.workers,retries,trace,video, hooks,test.skip,test.setTimeout,test.use, CLI flags,-u) go fromsametorenamed/missingand name their limits.test.fail()is nowsame. The row notes that members of a serial group and setup tests can't be marked (keeps main's feat(e2e): test.fail for tests expected to fail #1539 row).inputValue()on an element that isn't an input reads"", where Playwright throws (packages/e2e/src/locator/screen.ts:562).uncheck()on a checked radio,role=radioincluded, isNOT_ACTIONABLE(packages/web/src/actions.ts:59).?in abrowser.routeglob matches one character, where Playwright reads it literally.route.fulfillbodies are strings only, and each header takes one value, so oneset-cookie. Aroute.continueheader can't be deleted (packages/web/src/route-options.ts).{ timeout: 0 }:INVALID_ARGUMENTonwaitForResponse,waitForDownload, andtoHaveScreenshot. Any other call times out at once.visibility: hiddeniframe reads as visible.goto('data:')is nowby design. A new "What differs on purpose" bullet states the navigation rule:http,https, andabout:blankonly (packages/e2e/src/internal/urls.ts:137). That bullet replaces the undefined "navigation rule" reference.about:blankpage before the firstgoto.browser.evaluateand locator reads run in the page's main world.Rows describe how main behaves today. Open PRs that close gaps (clearing file inputs, binary bodies, header deletion, several
set-cookie, hidden iframes, isolated world) update their own rows.Verified
Ran it locally: yes
pnpm docs:check: 70 pages compile as MDX, and 1018 anchors resolve.packages/*/srcand the testbed marks. It found two false claims, both now fixed:test.skipinafterEach, andtimeout: 0on everybrowsercall.Checklist
pnpm changeset) for any change to a published package, or the change is testbed, docs, or CI only.