Skip to content

Match the Playwright migration mapping to what e2e does - #1061

Merged
kblok merged 2 commits into
mainfrom
issue-1059-playwright-migration
Nov 4, 2026
Merged

kblok merged 2 commits into
mainfrom
issue-1059-playwright-migration

Conversation

@kblok

@kblok kblok commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

The Playwright migration guide said some things e2e does not do. This PR makes the .NET guide state the real limits, so a migrating agent does not trust a "same" row that is not.

Upstream change ported: e2e-inc/e2e#1545, commit 0852e61 (docs/migrate/playwright.mdx). Each statement was checked against the port's code before it was added. Changed rows: trace and video limits, action options (Timeout only), UncheckAsync on a radio, empty SetInputFilesAsync, InputValueAsync on a non-input, .Not matchers (1 s hold), Expect.Poll timeout and interval, data: and other schemes (POLICY_DENIED), no page before the first open, route glob, fulfill and continue limits, zero timeouts, exact default. COMPATIBILITY.md lists the commit and what was left out.

Not mirrored (the port has no such feature, the framework owns it): workers and retries limits, test.skip, test.fail, test.use, hook rules, CLI flag rows, expect.closeTo, value-matcher list, soft assertions in afterEach. Not verified in the port, so left out: the **/ route glob rule and the hidden iframe visibility note.

No src/ symbols or tests changed, so there are no .NET-only symbols and no partial tests.

Closes #1059

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 77f48c2 and 63f0bba.

Files selected for processing: 2
  • COMPATIBILITY.md
  • docs-site/src/content/docs/migrate/playwright.mdx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

Review notes: kept renamed for the trace, video, and modifiers rows, as upstream does in 0852e61 (the status follows upstream). The 7-character SHA is how upstream prints it. Fixed the InputValueAsync, .Not.ToBeEnabledAsync, and zero-timeout rows.

@kblok
kblok merged commit fe81b9d into main Nov 4, 2026
4 checks passed
@kblok
kblok deleted the issue-1059-playwright-migration branch November 4, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upstream docs: match the Playwright migration mapping to what e2e does (#1545)

1 participant