Repository navigation
Match the Playwright migration mapping to what e2e does - #1061
Merged
Merged
Conversation
…1545) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 54 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Member
Author
|
Review notes: kept |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Playwright migration guide said some things e2e does not do. This PR makes the .NET guide state the real limits, so a migrating agent does not trust a "same" row that is not.
Upstream change ported: e2e-inc/e2e#1545, commit
0852e61(docs/migrate/playwright.mdx). Each statement was checked against the port's code before it was added. Changed rows: trace and video limits, action options (Timeoutonly),UncheckAsyncon a radio, emptySetInputFilesAsync,InputValueAsyncon a non-input,.Notmatchers (1 s hold),Expect.Polltimeout and interval,data:and other schemes (POLICY_DENIED), no page before the first open, route glob, fulfill and continue limits, zero timeouts,exactdefault.COMPATIBILITY.mdlists the commit and what was left out.Not mirrored (the port has no such feature, the framework owns it):
workersandretrieslimits,test.skip,test.fail,test.use, hook rules, CLI flag rows,expect.closeTo, value-matcher list, soft assertions inafterEach. Not verified in the port, so left out: the**/route glob rule and the hiddeniframevisibility note.No
src/symbols or tests changed, so there are no .NET-only symbols and no partial tests.Closes #1059
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK