Skip to content

Add multi-hypothesiser based MFA with multi-model example#1216

Open
sdhiscocks wants to merge 3 commits intomainfrom
mmmfa
Open

Add multi-hypothesiser based MFA with multi-model example#1216
sdhiscocks wants to merge 3 commits intomainfrom
mmmfa

Conversation

@sdhiscocks
Copy link
Copy Markdown
Member

No description provided.

@sdhiscocks sdhiscocks requested a review from a team as a code owner September 10, 2025 11:09
@sdhiscocks sdhiscocks requested review from hpritchett-dstl and orosoman-dstl and removed request for a team September 10, 2025 11:09
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 98.52941% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.05%. Comparing base (3ad3eb6) to head (3baf40e).

Files with missing lines Patch % Lines
stonesoup/hypothesiser/mfa.py 97.82% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1216      +/-   ##
==========================================
+ Coverage   93.99%   94.05%   +0.06%     
==========================================
  Files         227      227              
  Lines       15764    15808      +44     
  Branches     2177     2182       +5     
==========================================
+ Hits        14817    14869      +52     
+ Misses        657      654       -3     
+ Partials      290      285       -5     
Flag Coverage Δ
integration 66.68% <98.52%> (+0.10%) ⬆️
unittests 91.48% <95.58%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hpritchett-dstl
Copy link
Copy Markdown
Contributor

Only thing i can think of is to vectorize the multivariate normal logpdf calculation in each PDAHypothesiser. hypothsise call. We could potentially call each hypothesiser's predictor's predict and do one single vectorized batch_multivariate_normal_logpdf in MFAHypothesiser.hypothesise , and have these cached. I can see how this added bloat won't merit the speed increase though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants