-
Notifications
You must be signed in to change notification settings - Fork 0
add observe skill to go2 #1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add observe skill to go2 #1109
Conversation
Greptile OverviewGreptile SummaryThis PR adds an Key changes:
Implementation details:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Agent as AI Agent
participant GO2 as GO2Connection
participant VideoStream as Video Stream
participant Camera as Robot Camera
Note over VideoStream,Camera: Connection established & streaming started
Camera->>VideoStream: Continuous video frames
VideoStream->>GO2: onimage(image)
GO2->>GO2: self._latest_video_frame = image
GO2->>GO2: publish to color_image output
Note over Agent,GO2: Agent asks "what do you see?"
Agent->>GO2: observe() skill call
GO2->>Agent: return self._latest_video_frame
Agent->>Agent: Process image for visual query
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No files reviewed, no comments
|
|
||
| def onimage(image: Image) -> None: | ||
| self.color_image.publish(image) | ||
| self._latest_video_frame = image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as long as we are familiar with this but choosing to do _latest_video_frame thing I'm ok. idk if this API is too obscuring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did consider that (getter_hot), (since I reviewed the doc), but it seemed easier to just set the value (like the other skill does) since there already is a subscription for the image here.
leshy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just an API note
Run:
...and ask "what do you see" in 'humancli'`.