Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dimos/core/global_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class GlobalConfig(BaseSettings):
replay: bool = False
rerun_enabled: bool = True
rerun_server_addr: str | None = None
viewer_backend: ViewerBackend = "rerun-web"
viewer_backend: ViewerBackend = "rerun-native"
n_dask_workers: int = 2
memory_limit: str = "auto"
mujoco_camera_position: str | None = None
Expand Down
2 changes: 1 addition & 1 deletion dimos/dashboard/rerun_init.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
_rerun_init_lock = threading.Lock()


def init_rerun_server(viewer_mode: str = "rerun-web", memory_limit: str = "4GB") -> str:
def init_rerun_server(viewer_mode: str, memory_limit: str = "4GB") -> str:
"""Initialize Rerun server in the main process.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is incorrect below. Still refernces viewer mode

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile comment: The change is functionally correct and aligns with the documentation that describes rerun-native as offering better performance. However, the docstring comments in rerun_init.py still incorrectly reference rerun-web as the default in two places (lines 23 and 36).

Starts the gRPC server and optionally the web/native viewer.
Expand Down