better error reporting for Buechi conversion #1368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operty This improves the error reporting when the Buechi conversion is given an unsupported property.
kroening
force-pushed
the
ltl_to_buechi_unsupported
branch
from
199dc18 to
6c05d42
Compare
tautschnig
approved these changes
Oct 29, 2025
Comment on lines
+40
to
+43
| // make the automaton for the negation of the property | ||
| auto buechi = | ||
| ltl_to_buechi(not_exprt{property.normalized_expr}, message_handler); | ||
|
|
There was a problem hiding this comment.
I'm not entirely comfortable putting a large block of code into a try clause as it makes it far from clear which statements can raise an exception. Am I wrong in that ltl_to_buechi is actually the only call in here that can result in the specific exception that's later caught? I acknowledge that this is just me being uncomfortable, it's not a hard blocker.
There was a problem hiding this comment.
Yes, it is; this bugged me as well. To fix this, you'd need to extract that block into a function.
kroening
added a commit
that referenced
this pull request
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the error reporting when the Buechi conversion is given an unsupported property.