feat: proactively push recovered signatures; fully connect instantsend quorums for recovered sigs #6967

PastaPastaPasta · 2025-11-13T01:58:10Z

Issue being fixed or feature implemented

Currently; recovered sigs are send to other peers in a manner as described in https://github.com/dashpay/dips/blob/master/dip-0006.md#intra-quorum-communication

After the implementation of Concentrated Recovery for small quorums, this is no longer ideal. for cases where latency is of paramount importance, we can reuse the connections that are maintained to perform concentrated recovery for recovered signature propagation.

Additionally; we can proactively send recovered signatures to interested peers we are connected to when we are the member who performed recovery. For LLMQs that use concentrated recovery, typically only one peer will perform initial recovery, so sending out proactively makes sense.

What was done?

How Has This Been Tested?

Has been running on testnet for a while.

Breaking Changes

None

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation
I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

github-actions · 2025-11-13T01:58:54Z

⚠️ Potential Merge Conflicts Detected

This PR has potential conflicts with the following open PRs:

refactor: separate network and consensus logic 2a/N [signing] #6992 - refactor: separate network and consensus logic 2a/N [signing]

Please coordinate with the authors of these PRs to avoid merge conflicts.

DashCoreAutoGuix · 2025-11-13T02:00:06Z

Guix Automation has began to build this PR tagged as v23.0.0-devpr6967.f172589d. A new comment will be made when the image is pushed.

github-actions · 2025-11-13T02:16:38Z

This pull request has conflicts, please rebase.

DashCoreAutoGuix · 2025-11-13T03:42:52Z

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v23.0.0-devpr6967.f172589d. The image should be on dockerhub soon.

DashCoreAutoGuix · 2025-11-13T03:44:04Z

Guix Automation has began to build this PR tagged as v23.0.0-devpr6967.10b47ca5. A new comment will be made when the image is pushed.

DashCoreAutoGuix · 2025-11-13T04:47:07Z

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v23.0.0-devpr6967.10b47ca5. The image should be on dockerhub soon.

DashCoreAutoGuix · 2025-11-14T15:12:06Z

Guix Automation has began to build this PR tagged as v23.0.0-devpr6967.3c679369. A new comment will be made when the image is pushed.

DashCoreAutoGuix · 2025-11-14T16:18:51Z

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v23.0.0-devpr6967.3c679369. The image should be on dockerhub soon.

DashCoreAutoGuix · 2025-11-17T15:38:05Z

Guix Automation has began to build this PR tagged as v23.0.0-devpr6967.2e8ac6a7. A new comment will be made when the image is pushed.

DashCoreAutoGuix · 2025-11-17T16:47:57Z

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v23.0.0-devpr6967.2e8ac6a7. The image should be on dockerhub soon.

coderabbitai · 2025-11-18T14:50:39Z

Walkthrough

This pull request threads a new proactive relay flag through recovered-signature handling. CSigningManager::ProcessRecoveredSig gains a NodeId from parameter to determine proactive_relay. Notification and relay APIs are updated to accept the flag: validation signals, sigshares, active/zmq notifiers, and PeerManager::RelayRecoveredSig now accept/provide proactive_relay; RelayRecoveredSig also now takes a full CRecoveredSig. Quorum relay selection logic in llmq utils was simplified to use connection sets directly. Multiple call sites were updated accordingly across signing, networking, validation, and ZMQ code.

Sequence Diagram(s)

sequenceDiagram
    participant SM as CSigningManager
    participant VS as CMainSignals / ValidationInterface
    participant SSM as CSigSharesManager
    participant PM as PeerManager
    participant ZMQ as ZMQNotifiers

    rect rgb(230,240,255)
    Note over SM: Recovered sig arrives
    SM->>SM: ProcessRecoveredSig(sig, peerman, from)
    SM->>SM: compute proactive_relay (from, llmqType)
    SM->>VS: NotifyRecoveredSig(sig, id, proactive_relay)
    end

    rect rgb(240,230,255)
    VS->>SSM: NotifyRecoveredSig(sig, proactive_relay)
    SSM->>PM: RelayRecoveredSig(sig, proactive_relay)
    end

    rect rgb(255,240,230)
    alt proactive_relay == true
        PM->>PM: Proactively broadcast QSIGREC to peers wanting rec sigs
    else
        PM->>PM: Relay via inventory (MSG_QUORUM_RECOVERED_SIG)
    end
    end

    rect rgb(230,255,240)
    PM->>ZMQ: NotifyRecoveredSig(sig, proactive_relay)
    ZMQ->>ZMQ: Publish to subscribers (hash/raw as configured)
    end

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Areas requiring extra attention during review:

src/llmq/signing.cpp / src/llmq/signing.h: correctness of from threading and proactive_relay computation (which llmq types are excluded).
src/net_processing.cpp / src/net_processing.h: new proactive broadcast path (QSIGREC) vs. inventory relay; peer filtering and early-return behavior.
src/llmq/signing_shares.* and src/masternode/active/notificationinterface.*: consistent signature changes and locking annotations for NotifyRecoveredSig.
src/llmq/utils.cpp: changes to quorum relay member selection and removal of separate relayMembers logic.
src/validationinterface.* and src/zmq/*: ensure all notifier interfaces and implementations correctly accept and forward the new boolean parameter.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 5.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main changes: proactively pushing recovered signatures and fully connecting instantsend quorums, which aligns with the extensive signature propagation and relay logic changes shown throughout the changeset.
Description check	✅ Passed	The PR description adequately describes the changes: it explains that recovered signatures are being sent proactively using concentrated recovery connections, which aligns with the code changes that add proactive_relay parameter propagation throughout the codebase.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (3)

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between caf5010 and 2e8ac6a.

📒 Files selected for processing (17)

src/llmq/signing.cpp (4 hunks)
src/llmq/signing.h (1 hunks)
src/llmq/signing_shares.cpp (3 hunks)
src/llmq/signing_shares.h (1 hunks)
src/llmq/utils.cpp (1 hunks)
src/masternode/active/notificationinterface.cpp (1 hunks)
src/masternode/active/notificationinterface.h (1 hunks)
src/net_processing.cpp (2 hunks)
src/net_processing.h (1 hunks)
src/validationinterface.cpp (1 hunks)
src/validationinterface.h (2 hunks)
src/zmq/zmqabstractnotifier.cpp (1 hunks)
src/zmq/zmqabstractnotifier.h (1 hunks)
src/zmq/zmqnotificationinterface.cpp (1 hunks)
src/zmq/zmqnotificationinterface.h (1 hunks)
src/zmq/zmqpublishnotifier.cpp (2 hunks)
src/zmq/zmqpublishnotifier.h (2 hunks)

🧰 Additional context used

🧠 Learnings (4)

📓 Common learnings

Learnt from: kwvg
Repo: dashpay/dash PR: 6761
File: src/chainlock/signing.cpp:247-250
Timestamp: 2025-07-29T14:32:48.369Z
Learning: In PR #6761, kwvg acknowledged a null pointer check issue in ChainLockSigner::Cleanup() method but deferred it to follow-up, consistent with the pattern of avoiding scope creep in refactoring PRs.

📚 Learning: 2025-07-15T14:53:04.819Z

Learnt from: knst
Repo: dashpay/dash PR: 6691
File: src/test/llmq_params_tests.cpp:148-151
Timestamp: 2025-07-15T14:53:04.819Z
Learning: In the Dash Core LLMQ implementation, signingActiveQuorumCount is never 0 in the actual parameters defined in params.h, making division by zero scenarios unrealistic in the max_cycles() function.

Applied to files:

src/llmq/signing.cpp

📚 Learning: 2025-10-02T18:29:54.756Z

Learnt from: kwvg
Repo: dashpay/dash PR: 6840
File: src/net_processing.cpp:2882-2886
Timestamp: 2025-10-02T18:29:54.756Z
Learning: Across net_processing.cpp, once LLMQContext (m_llmq_ctx) is asserted non-null, its subcomponents (e.g., isman, qdkgsman, quorum_block_processor) are treated as initialized and used without extra null checks.

Applied to files:

src/llmq/utils.cpp

📚 Learning: 2025-08-19T15:08:00.835Z

Learnt from: knst
Repo: dashpay/dash PR: 6692
File: src/llmq/commitment.cpp:54-60
Timestamp: 2025-08-19T15:08:00.835Z
Learning: In Dash Core, llmq_params.size == 1 is used only for regtest environments, not on public networks, which significantly reduces the risk profile of code paths specific to single-member quorums.

Applied to files:

src/llmq/utils.cpp

🧬 Code graph analysis (15)

src/net_processing.h (3)

src/masternode/active/notificationinterface.h (6)

src/llmq/signing.h (1)

src/zmq/zmqpublishnotifier.h (7)

src/zmq/zmqabstractnotifier.cpp (5)

src/validationinterface.h (7)

src/zmq/zmqnotificationinterface.cpp (6)

src/zmq/zmqabstractnotifier.h (7)

src/llmq/signing_shares.h (7)

src/zmq/zmqpublishnotifier.cpp (6)

src/zmq/zmqnotificationinterface.h (7)

src/masternode/active/notificationinterface.cpp (6)

src/validationinterface.cpp (6)

src/llmq/signing.cpp (1)

src/llmq/signing_shares.cpp (6)

🪛 GitHub Actions: Clang Diff Format Check

src/llmq/signing_shares.h

[error] 1-1: Clang format differences found in src/llmq/signing_shares.h. Run the clang-format-diff tool or clang-format to fix formatting changes.

src/masternode/active/notificationinterface.cpp

[error] 1-1: Clang format differences found in src/masternode/active/notificationinterface.cpp. Run the clang-format-diff tool or clang-format to fix formatting changes.

src/llmq/signing.cpp

[error] 1-1: Clang format differences found in src/llmq/signing.cpp. Run the clang-format-diff tool or clang-format to fix formatting changes.

🔇 Additional comments (16)

coderabbitai · 2025-11-18T14:50:42Z

src/llmq/signing_shares.h

                           bool allowDiffMsgHashSigning = false) EXCLUSIVE_LOCKS_REQUIRED(!cs_pendingSigns, !cs);

-    void NotifyRecoveredSig(const std::shared_ptr<const CRecoveredSig>& sig) const EXCLUSIVE_LOCKS_REQUIRED(!cs);
+    void NotifyRecoveredSig(const std::shared_ptr<const CRecoveredSig>& sig, bool proactive_relay) const EXCLUSIVE_LOCKS_REQUIRED(!cs);


⚠️ Potential issue | 🟡 Minor

Recovered‑sig notification wiring is correct; fix clang‑format to unbreak CI

The new NotifyRecoveredSig(const std::shared_ptr<const CRecoveredSig>& sig, bool proactive_relay) const EXCLUSIVE_LOCKS_REQUIRED(!cs) overload is consistent with its implementation in signing_shares.cpp and with the locking strategy (no cs held while calling PeerManager::RelayRecoveredSig). Semantics look good.

CI is currently failing on src/llmq/signing_shares.h due to a clang‑format diff, though. Please run the project’s clang‑format tooling on this file (or at least around this declaration) and commit the resulting formatting changes so the pipeline passes.

🤖 Prompt for AI Agents

In src/llmq/signing_shares.h around line 452, the new overload declaration is correctly implemented but its formatting doesn't match the project's clang-format rules and is causing CI failures; run the project's clang-format tool (or apply the repo's clang-format style) to reformat this file or at least the vicinity of this declaration, update the header with the formatted result, and commit that change so the CI clang-format check passes.

coderabbitai · 2025-11-18T14:50:42Z

src/masternode/active/notificationinterface.cpp

+void ActiveNotificationInterface::NotifyRecoveredSig(const std::shared_ptr<const llmq::CRecoveredSig>& sig, bool proactive_relay)
 {
-    m_active_ctx.shareman->NotifyRecoveredSig(sig);
+    m_active_ctx.shareman->NotifyRecoveredSig(sig, proactive_relay);


⚠️ Potential issue | 🟡 Minor

Fix clang-format issues.

The CI pipeline reports formatting differences in this file. Please run clang-format to resolve the formatting issues before merging.

Run the following command to fix formatting:

#!/bin/bash # Format the file according to project style clang-format -i src/masternode/active/notificationinterface.cpp

🤖 Prompt for AI Agents

In src/masternode/active/notificationinterface.cpp around lines 32 to 34, the file fails CI due to clang-format style differences; run clang-format -i on that file to reformat it (or apply your project's clang-format settings) so the NotifyRecoveredSig function and surrounding whitespace/indentation match project style, then re-run clang-format or the CI linter and commit the updated file.

src/llmq/utils.cpp

DashCoreAutoGuix · 2025-11-19T21:02:04Z

Guix Automation has began to build this PR tagged as v23.0.0-devpr6967.e404e679. A new comment will be made when the image is pushed.

DashCoreAutoGuix · 2025-11-19T22:07:28Z

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v23.0.0-devpr6967.e404e679. The image should be on dockerhub soon.

…ho performed recovery

… connections for all members

src/llmq/signing.cpp

src/zmq/zmqabstractnotifier.h

…fier`

PastaPastaPasta · 2025-11-25T14:02:57Z

Resolved! Forgot to push that final change

DashCoreAutoGuix · 2025-11-25T14:22:57Z

Guix Automation has began to build this PR tagged as v23.0.0-devpr6967.def66c9c. A new comment will be made when the image is pushed.

DashCoreAutoGuix · 2025-11-25T14:23:16Z

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v23.0.0-devpr6967.def66c9c. The image should be on dockerhub soon.

DashCoreAutoGuix · 2025-11-25T14:28:05Z

Guix Automation has began to build this PR tagged as v23.0.0-devpr6967.ca6369bd. A new comment will be made when the image is pushed.

DashCoreAutoGuix · 2025-11-25T14:28:23Z

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v23.0.0-devpr6967.ca6369bd. The image should be on dockerhub soon.

UdjinM6

what are all these "chore: empty" commits about?

src/llmq/signing.cpp

DashCoreAutoGuix · 2025-11-25T23:04:05Z

Guix Automation has began to build this PR tagged as v23.0.0-devpr6967.8747a552. A new comment will be made when the image is pushed.

DashCoreAutoGuix · 2025-11-26T00:11:20Z

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v23.0.0-devpr6967.8747a552. The image should be on dockerhub soon.

DashCoreAutoGuix · 2025-11-26T14:10:06Z

Guix Automation has began to build this PR tagged as v23.0.0-devpr6967.f18a12e8. A new comment will be made when the image is pushed.

UdjinM6

utACK f18a12e

DashCoreAutoGuix · 2025-11-26T15:18:19Z

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v23.0.0-devpr6967.f18a12e8. The image should be on dockerhub soon.

kwvg

Conceptual ACK, see suggestions

kwvg · 2025-11-29T07:46:16Z

src/zmq/zmqnotificationinterface.cpp

 }

-void CZMQNotificationInterface::NotifyRecoveredSig(const std::shared_ptr<const llmq::CRecoveredSig>& sig)
+void CZMQNotificationInterface::NotifyRecoveredSig(const std::shared_ptr<const llmq::CRecoveredSig>& sig, bool /*proactive_relay*/)


Suggested change

void CZMQNotificationInterface::NotifyRecoveredSig(const std::shared_ptr<const llmq::CRecoveredSig>& sig, bool /*proactive_relay*/)

void CZMQNotificationInterface::NotifyRecoveredSig(const std::shared_ptr<const llmq::CRecoveredSig>& sig, [[maybe_unused]] bool proactive_relay)

src/validationinterface.h

src/llmq/signing_shares.cpp

kwvg · 2025-11-29T07:49:42Z

src/llmq/signing.cpp

-    GetMainSignals().NotifyRecoveredSig(recoveredSig, recoveredSig->GetHash().ToString());
+    // TODO refactor to use a better abstraction analogous to IsAllMembersConnectedEnabled
+    auto proactive_relay = from == -1 &&
+                           llmqType != Consensus::LLMQType::LLMQ_100_67 &&


Can we document why these LLMQs are excluded from proactive relay? Either by placing them in a dedicated function or by comment? Similar exclusions are present in llmq/options.cpp (see below) but aren't immediately clear why.

dash/src/llmq/options.cpp

Lines 28 to 30 in 199ac79

if (spork_value == 1 && llmqType != Consensus::LLMQType::LLMQ_100_67 && llmqType != Consensus::LLMQType::LLMQ_400_60 && llmqType != Consensus::LLMQType::LLMQ_400_85) {

return true;

}

src/llmq/signing.h

src/llmq/signing.cpp

Co-authored-by: Kittywhiskers Van Gogh <[email protected]>

DashCoreAutoGuix · 2025-11-29T16:44:04Z

Guix Automation has failed due to the HEAD commit not being signed by an authorized core-team member. Please rebase and sign or push a new empty signed commit to allow Guix build to happen.

UdjinM6

utACK a58f1bb

kwvg

utACK a58f1bb

PastaPastaPasta added the guix-build label Nov 13, 2025

github-actions bot added the needs rebase label Nov 13, 2025

PastaPastaPasta force-pushed the feat/proactively-push-recsig branch from f172589 to 10b47ca Compare November 13, 2025 02:23

github-actions bot removed the needs rebase label Nov 13, 2025

PastaPastaPasta changed the title ~~Feat/proactively push recsig~~ feat: proactively push recovered signatures; fully connect instantsend quorums for recovered sigs Nov 13, 2025

PastaPastaPasta force-pushed the feat/proactively-push-recsig branch from 10b47ca to 3c67936 Compare November 14, 2025 15:10

PastaPastaPasta force-pushed the feat/proactively-push-recsig branch from 3c67936 to 2e8ac6a Compare November 17, 2025 15:37

PastaPastaPasta marked this pull request as ready for review November 18, 2025 14:40

coderabbitai bot reviewed Nov 18, 2025

View reviewed changes

This was referenced Nov 19, 2025

refactor: avoid return by reference and prefer return by value #6955

Open

refactor: separate network and consensus logic 2a/N [signing] #6992

Merged

UdjinM6 reviewed Nov 19, 2025

View reviewed changes

src/llmq/utils.cpp Outdated Show resolved Hide resolved

PastaPastaPasta force-pushed the feat/proactively-push-recsig branch from e404e67 to 7e782ff Compare November 21, 2025 17:42

PastaPastaPasta requested review from UdjinM6 and knst November 24, 2025 14:57

PastaPastaPasta added 2 commits November 24, 2025 11:30

feat: proactively relay recovered signatures when we are the member w…

7be3d4a

…ho performed recovery

feat: enhance recovered signature propagation by leveraging full-mesh…

4e449d0

… connections for all members

PastaPastaPasta added 2 commits November 24, 2025 11:30

fix: proper include syntax

9f27cfb

fix: avoid improper dual way connection attempts

a57a811

PastaPastaPasta force-pushed the feat/proactively-push-recsig branch from 7e782ff to a57a811 Compare November 24, 2025 17:30

UdjinM6 reviewed Nov 24, 2025

View reviewed changes

src/llmq/signing.cpp Outdated Show resolved Hide resolved

src/zmq/zmqabstractnotifier.h Outdated Show resolved Hide resolved

refactor: avoid passing unused proactive_relay to `CZMQAbstractNoti…

08a3a18

…fier`

UdjinM6 added this to the 23.1 milestone Nov 24, 2025

UdjinM6 reviewed Nov 25, 2025

View reviewed changes

src/llmq/signing.cpp Outdated Show resolved Hide resolved

fix: use llmq/params.h

f18a12e

PastaPastaPasta force-pushed the feat/proactively-push-recsig branch from 8747a55 to f18a12e Compare November 26, 2025 14:08

UdjinM6 previously approved these changes Nov 26, 2025

View reviewed changes

kwvg reviewed Nov 29, 2025

View reviewed changes

trivial: add a few comments and fix reference location

a58f1bb

Co-authored-by: Kittywhiskers Van Gogh <[email protected]>

PastaPastaPasta dismissed UdjinM6’s stale review via a58f1bb November 29, 2025 16:42

UdjinM6 approved these changes Nov 29, 2025

View reviewed changes

github-actions bot mentioned this pull request Nov 30, 2025

backport: merge bitcoin#24595 (move g_versionbitscache global to ChainstateManager) #6933

Open

5 tasks

kwvg approved these changes Dec 1, 2025

View reviewed changes

PastaPastaPasta merged commit 4bbdc7f into dashpay:develop Dec 2, 2025
31 of 35 checks passed

	void CZMQNotificationInterface::NotifyRecoveredSig(const std::shared_ptr<const llmq::CRecoveredSig>& sig, bool /proactive_relay/)
	void CZMQNotificationInterface::NotifyRecoveredSig(const std::shared_ptr<const llmq::CRecoveredSig>& sig, [[maybe_unused]] bool proactive_relay)

	if (spork_value == 1 && llmqType != Consensus::LLMQType::LLMQ_100_67 && llmqType != Consensus::LLMQType::LLMQ_400_60 && llmqType != Consensus::LLMQType::LLMQ_400_85) {
	return true;
	}

feat: proactively push recovered signatures; fully connect instantsend quorums for recovered sigs #6967

feat: proactively push recovered signatures; fully connect instantsend quorums for recovered sigs #6967

Uh oh!

Conversation

PastaPastaPasta commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

Uh oh!

github-actions bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Potential Merge Conflicts Detected

Uh oh!

DashCoreAutoGuix commented Nov 13, 2025

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

DashCoreAutoGuix commented Nov 13, 2025

Uh oh!

DashCoreAutoGuix commented Nov 13, 2025

Uh oh!

DashCoreAutoGuix commented Nov 13, 2025

Uh oh!

DashCoreAutoGuix commented Nov 14, 2025

Uh oh!

DashCoreAutoGuix commented Nov 14, 2025

Uh oh!

DashCoreAutoGuix commented Nov 17, 2025

Uh oh!

DashCoreAutoGuix commented Nov 17, 2025

Uh oh!

coderabbitai bot commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Sequence Diagram(s)

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DashCoreAutoGuix commented Nov 19, 2025

Uh oh!

DashCoreAutoGuix commented Nov 19, 2025

Uh oh!

Uh oh!

Uh oh!

PastaPastaPasta commented Nov 25, 2025

Uh oh!

DashCoreAutoGuix commented Nov 25, 2025

Uh oh!

DashCoreAutoGuix commented Nov 25, 2025

Uh oh!

DashCoreAutoGuix commented Nov 25, 2025

Uh oh!

DashCoreAutoGuix commented Nov 25, 2025

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DashCoreAutoGuix commented Nov 25, 2025

Uh oh!

DashCoreAutoGuix commented Nov 26, 2025

Uh oh!

DashCoreAutoGuix commented Nov 26, 2025

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta commented Nov 13, 2025 •

edited

Loading

github-actions bot commented Nov 13, 2025 •

edited

Loading

coderabbitai bot commented Nov 18, 2025 •

edited

Loading