-
Notifications
You must be signed in to change notification settings - Fork 3
Allow to customize Plexus container by test class #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,7 +58,7 @@ | |
* This is a slightly modified version of the original plexus class | ||
* available at https://raw.githubusercontent.com/codehaus-plexus/plexus-containers/master/plexus-container-default/ | ||
* src/main/java/org/codehaus/plexus/PlexusTestCase.java | ||
* in order to migrate the tests to JUnit 4. | ||
* in order to migrate the tests to JUnit 5. | ||
* | ||
* @author Jason van Zyl | ||
* @author <a href="mailto:[email protected]">Trygve Laugstøl</a> | ||
|
@@ -94,7 +94,6 @@ protected void setContext(ExtensionContext context) { | |
this.context = context; | ||
} | ||
|
||
@SuppressWarnings("ResultOfMethodCallIgnored") | ||
protected void setupContainer() { | ||
// ---------------------------------------------------------------------------- | ||
// Context Setup | ||
|
@@ -136,12 +135,14 @@ protected void setupContainer() { | |
} | ||
|
||
customizeContainerConfiguration(containerConfiguration); | ||
testInstanceCustomizeContainerConfiguration(containerConfiguration); | ||
|
||
try { | ||
container = new DefaultPlexusContainer(containerConfiguration); | ||
} catch (PlexusContainerException e) { | ||
throw new IllegalArgumentException("Failed to create plexus container.", e); | ||
} | ||
testInstanceCustomizeContainer(container); | ||
} | ||
|
||
/** | ||
|
@@ -155,6 +156,20 @@ protected void customizeContainerConfiguration(ContainerConfiguration containerC | |
containerConfiguration.setClassPathScanning(PlexusConstants.SCANNING_INDEX); | ||
} | ||
|
||
private void testInstanceCustomizeContainerConfiguration(ContainerConfiguration containerConfiguration) { | ||
Object testInstance = context.getRequiredTestInstance(); | ||
if (testInstance instanceof PlexusTestConfiguration) { | ||
((PlexusTestConfiguration) testInstance).customizeConfiguration(containerConfiguration); | ||
} | ||
} | ||
|
||
private void testInstanceCustomizeContainer(PlexusContainer container) { | ||
Object testInstance = context.getRequiredTestInstance(); | ||
if (testInstance instanceof PlexusTestConfiguration) { | ||
((PlexusTestConfiguration) testInstance).customizeContainer(container); | ||
} | ||
} | ||
|
||
protected void customizeContext(Context context) {} | ||
|
||
protected PlexusConfiguration customizeComponentConfiguration() { | ||
|
28 changes: 28 additions & 0 deletions
28
src/main/java/org/codehaus/plexus/testing/PlexusTestConfiguration.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
package org.codehaus.plexus.testing; | ||
|
||
import org.codehaus.plexus.ContainerConfiguration; | ||
import org.codehaus.plexus.PlexusContainer; | ||
|
||
/** | ||
* Allow to customize the Plexus container by test class. | ||
* | ||
* @since 1.7.0 | ||
*/ | ||
public interface PlexusTestConfiguration { | ||
|
||
/** | ||
* Customize the container configuration before the container is created. | ||
* | ||
* @param containerConfiguration the container configuration to customize | ||
* @since 1.7.0 | ||
*/ | ||
default void customizeConfiguration(ContainerConfiguration containerConfiguration) {} | ||
|
||
/** | ||
* Customize the container after it has been created. | ||
* | ||
* @param container the container to customize | ||
* @since 1.7.0 | ||
*/ | ||
default void customizeContainer(PlexusContainer container) {} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
src/test/java/org/codehaus/plexus/testing/PlexusTestCustomizeTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
package org.codehaus.plexus.testing; | ||
|
||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
// START SNIPPET: test-customize-class | ||
import javax.inject.Inject; | ||
|
||
import org.codehaus.plexus.PlexusContainer; | ||
import org.junit.jupiter.api.Test; | ||
import org.junit.jupiter.api.extension.ExtendWith; | ||
import org.mockito.Mock; | ||
import org.mockito.junit.jupiter.MockitoExtension; | ||
|
||
import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
import static org.junit.jupiter.api.Assertions.assertSame; | ||
|
||
// MockitoExtension must be first | ||
@ExtendWith(MockitoExtension.class) | ||
@PlexusTest | ||
class PlexusTestCustomizeTest implements PlexusTestConfiguration { | ||
|
||
@Mock | ||
private TestJavaxComponent2 mockComponent2; | ||
|
||
/* | ||
Customize the container configuration before it is used to create the container. | ||
|
||
Method has default empty implementation so not need to implement if not used. | ||
|
||
@Override | ||
public void customizeConfiguration(ContainerConfiguration containerConfiguration) { | ||
|
||
} | ||
*/ | ||
|
||
@Override | ||
public void customizeContainer(PlexusContainer container) { | ||
container.addComponent(mockComponent2, TestJavaxComponent2.class.getName()); | ||
} | ||
|
||
@Inject | ||
private TestJavaxComponent testJavaxComponent; | ||
|
||
@Test | ||
void dependencyShouldBeInjected() { | ||
assertNotNull(testJavaxComponent); | ||
assertSame(testJavaxComponent.getTestComponent2(), mockComponent2); | ||
} | ||
} | ||
// END SNIPPET: test-customize-class |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add here a comment that another customize method exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slawekjaranowski
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sparsick done ... and docs also updated