Allow to customize Plexus container by test class #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekjaranowski
force-pushed
the
container-config
branch
from
7829f1f to
377532b
Compare
|
@sparsick please look |
|
Tested with One suggestion: I would add a sentence that the interface also has a method for customizing the configuration. |
Please point where do you want add such sentence. |
sparsick
reviewed
Oct 14, 2025
| private TestJavaxComponent2 mockComponent2; | ||
|
|
||
| @Override | ||
| public void customizeContainer(PlexusContainer container) { |
There was a problem hiding this comment.
I would add here a comment that another customize method exists
There was a problem hiding this comment.
@sparsick done ... and docs also updated
slawekjaranowski
force-pushed
the
container-config
branch
from
377532b to
16eb193
Compare
slawekjaranowski
requested review from
gnodet and
sparsick
and removed request for
sparsick
sparsick
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.