Skip to content

Change flatlist configuration for Explore page #9083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change flatlist configuration for Explore page #9083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/screens/Search/Explore.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,12 +1072,26 @@ export function Explore({
windowSize={platform({android: 11})}
/**
* Default: 10
*
* NOTE: This was 1 on Android. Unfortunately this leads to the list totally freaking out
* when the sticky headers changed. I made a minimal reproduction and yeah, it's this prop.
* Totally fine when the sticky headers are static, but when they're dynamic, it's a mess.
*
* Repro: https://github.com/mozzius/stickyindices-repro
*
* I then found doubling this prop on iOS also reduced it freaking out there as well.
*
* Trades off seeing more blank space due to it having to render more items before it can show anything.
* -sfn
*/
maxToRenderPerBatch={platform({android: 1})}
maxToRenderPerBatch={platform({android: 10, ios: 20})}
/**
* Default: 50
*
* NOTE: This was 25 on Android. However, due to maxToRenderPerBatch being set to 10,
* the lower batching period is no longer necessary (?)
*/
updateCellsBatchingPeriod={platform({android: 25})}
updateCellsBatchingPeriod={50}
refreshing={isPTR}
onRefresh={onPTR}
/>
Expand Down
Loading