Change flatlist configuration for Explore page #9083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to chase down the android perf/crashing issues, I focused in on the explore page (as I got a crash there). while I am no closer on the crashes, I think I may have figured out how to improve the issue of the sticky headers in the feed preview freaking out.
Seems like setting a low
maxToRenderPerBatchand then havingstickyHeaderIndicesthat change dynamically don't mix well at all. I made a minimal repro so you can play around with it: https://github.com/mozzius/stickyindices-reproYou can fix the freakout by either:
maxToRenderPerBatchstickyHeaderIndicesstaticSince we have to have dynamic
stickyHeaderIndices(as we add one every time we load another feed), the fix is to increasemaxToRenderPerBatch. Surprisingly, increasing it improves both platforms, but has the downside of more "blank-outs" where nothing is visible. Hopefully new arch fixes this? Or maybe LegendList :)Before
screen-20250925-175348.mp4
After
screen-20250925-175259.mp4