-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Atmosphere occlusion and PBR shading #21383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atmosphere occlusion and PBR shading #21383
Conversation
|
It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note. Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Sorry I didn't review earlier, I've been pretty busy :)
f1e613e to
5f718c5
Compare
Co-authored-by: atlv <[email protected]>
alice-i-cecile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing release notes still ;) Perils of making pretty features.
Once there's at least a stub though, ping me and I'll merge!
|
Ah fair! I missed those, will publish the release notes. Thanks 😊 |
|
Taking a look at why the merge is failing! |
|
Yep, looks like WASM builds are properly broken with this :) Let me know when you have a fix! |
|
@alice-i-cecile Thanks for working with me on merging this PR! <3 Unrelated problem to the CI being blocked, but ran into it while testing: I ran the CI tests locally and it's passing so it's likely just broken in github actions. |
e5d50e0 to
be4e9c4
Compare
Objective
Solution
Testing
cargo run --example atmosphere # or cargo run --example atmosphere --features=free_cameraShowcase