2789 - Add generic skip link 'skipContent' translations - (PV Carousel only)[Copilot]#14211
Open
Louis-Matsika wants to merge 5 commits into
Open
2789 - Add generic skip link 'skipContent' translations - (PV Carousel only)[Copilot]#14211Louis-Matsika wants to merge 5 commits into
Louis-Matsika wants to merge 5 commits into
Conversation
Louis-Matsika
changed the title
Louis-Matsika
changed the title
…om:bbc/simorgh into WS-2789-add-generic-skip-link-translations
Louis-Matsika
changed the title
Nabeel1276
reviewed
Jul 14, 2026
Nabeel1276
left a comment
Nabeel1276
left a comment
Contributor
There was a problem hiding this comment.
The spreadsheet's Sinhala row is clean, with no Persian text (වීඩියෝ කැරසල් මඟහරින්න / වීඩියෝ කැරසල් අවසානය). The ادامه in sinhala.ts must have been introduced during generation, not sourced from the spreadsheet it seems. Am I missing something?
Contributor
This is what we see in spreadsheet.
It has Persian presence.
Which column are you looking into in spreadsheet?
@Nabeel1276
|
jinidev
approved these changes
Jul 15, 2026
Contributor
The one in the ticket here - https://bbc.atlassian.net/browse/WS-2789 @jinidev |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardises the PortraitVideoCarousel skip-link copy by introducing a new, generic translations.skipContent entry (with %title% detokenisation) and updating the component + tests to use it, while adding the new translation key across service configs (including multi-variant services).
Changes:
- Added optional
skipContent(text + end marker visually hidden text) to the sharedTranslationstype. - Added
skipContenttranslations across services (including variants), using%title%tokens. - Updated
PortraitVideoCarouseland its tests to usetranslations.skipContentwith an English fallback.
Reviewed changes
Copilot reviewed 54 out of 54 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/models/types/translations.ts | Extends Translations with optional skipContent structure. |
| src/app/lib/config/services/zhongwen.ts | Adds skipContent translations for both simplified/traditional variants. |
| src/app/lib/config/services/yoruba.ts | Adds skipContent translations. |
| src/app/lib/config/services/ws.ts | Adds skipContent translations (English). |
| src/app/lib/config/services/vietnamese.ts | Adds skipContent translations. |
| src/app/lib/config/services/uzbek.ts | Adds skipContent translations for Cyrillic/Latin variants. |
| src/app/lib/config/services/urdu.ts | Adds skipContent translations. |
| src/app/lib/config/services/ukrainian.ts | Adds skipContent translations. |
| src/app/lib/config/services/ukchina.ts | Adds skipContent translations for both simplified/traditional variants. |
| src/app/lib/config/services/turkce.ts | Adds skipContent translations. |
| src/app/lib/config/services/tigrinya.ts | Adds skipContent translations. |
| src/app/lib/config/services/thai.ts | Adds skipContent translations. |
| src/app/lib/config/services/telugu.ts | Adds skipContent translations. |
| src/app/lib/config/services/tamil.ts | Adds skipContent translations. |
| src/app/lib/config/services/swahili.ts | Adds skipContent translations. |
| src/app/lib/config/services/sport.ts | Adds skipContent translations (English). |
| src/app/lib/config/services/somali.ts | Adds skipContent translations. |
| src/app/lib/config/services/sinhala.ts | Adds skipContent translations. |
| src/app/lib/config/services/serbian.ts | Adds skipContent translations for Latin/Cyrillic variants. |
| src/app/lib/config/services/scotland.ts | Adds skipContent translations (English). |
| src/app/lib/config/services/russian.ts | Adds skipContent translations. |
| src/app/lib/config/services/romania.ts | Adds skipContent translations. |
| src/app/lib/config/services/punjabi.ts | Adds skipContent translations. |
| src/app/lib/config/services/portuguese.ts | Adds skipContent translations. |
| src/app/lib/config/services/polska.ts | Adds skipContent translations. |
| src/app/lib/config/services/pidgin.ts | Adds skipContent translations (English copy). |
| src/app/lib/config/services/persian.ts | Adds skipContent translations. |
| src/app/lib/config/services/pashto.ts | Adds skipContent translations. |
| src/app/lib/config/services/newsround.ts | Adds skipContent translations (English). |
| src/app/lib/config/services/news.ts | Adds skipContent translations (English). |
| src/app/lib/config/services/nepali.ts | Adds skipContent translations. |
| src/app/lib/config/services/mundo.ts | Adds skipContent translations. |
| src/app/lib/config/services/marathi.ts | Adds skipContent translations. |
| src/app/lib/config/services/magyarul.ts | Adds skipContent translations. |
| src/app/lib/config/services/kyrgyz.ts | Adds skipContent translations. |
| src/app/lib/config/services/korean.ts | Adds skipContent translations. |
| src/app/lib/config/services/japanese.ts | Adds skipContent translations. |
| src/app/lib/config/services/indonesia.ts | Adds skipContent translations. |
| src/app/lib/config/services/igbo.ts | Adds skipContent translations. |
| src/app/lib/config/services/hindi.ts | Adds skipContent translations. |
| src/app/lib/config/services/hausa.ts | Adds skipContent translations. |
| src/app/lib/config/services/gujarati.ts | Adds skipContent translations. |
| src/app/lib/config/services/gahuza.ts | Adds skipContent translations. |
| src/app/lib/config/services/dari.ts | Adds skipContent translations. |
| src/app/lib/config/services/burmese.ts | Adds skipContent translations. |
| src/app/lib/config/services/bengali.ts | Adds skipContent translations. |
| src/app/lib/config/services/azeri.ts | Adds skipContent translations. |
| src/app/lib/config/services/archive.ts | Adds skipContent translations (English). |
| src/app/lib/config/services/arabic.ts | Adds skipContent translations. |
| src/app/lib/config/services/amharic.ts | Adds skipContent translations. |
| src/app/lib/config/services/afrique.ts | Adds skipContent translations. |
| src/app/lib/config/services/afaanoromoo.ts | Adds skipContent translations. |
| src/app/components/PortraitVideoCarousel/index.tsx | Switches skip-link source to translations.skipContent and updates fallback copy. |
| src/app/components/PortraitVideoCarousel/index.test.tsx | Updates assertions to match the new generic skip-link text. |
Isabella-Mitchell
approved these changes
Jul 16, 2026
Isabella-Mitchell
left a comment
Isabella-Mitchell
left a comment
Contributor
There was a problem hiding this comment.
Ran copilot just to checkover the translations (in the past I've found it's good at proof reading the languages and pointing out anything that looks odd!) Looks good :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*copilot generated description
JIRA: WS-2789
Summary
This pull request updates the "Skip" link logic and translations for the
PortraitVideoCarouselcomponent, improving how skip link text is handled and adding new translation keys for better localization. The changes affect both the component logic and the service configuration files for multiple languages.Code changes
Added optional
skipContent(text+endTextVisuallyHidden) to theTranslationstype intranslations.ts.Added
skipContenttranslations to the top level of translations for all mapped service configs, including multi-variant services:Also converted the source
${title}placeholder to the codebase's%title%detokeniser convention.Refactored
PortraitVideoCarouselto readtranslations.skipContent(with an English fallback) instead ofrecommendations.skipLink, and removed the now-unusedrecommendationsdestructure.Updated
PortraitVideoCarousel/index.test.tsxskip-link assertions to use the new generic text.Testing
http://localhost:7081/mundo/live/cjnk1wrpkdk7tskipContenttext