-
Notifications
You must be signed in to change notification settings - Fork 277
test: use generated ABI #1912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
test: use generated ABI #1912
Conversation
…test Signed-off-by: Jonathan Oppenheimer <[email protected]>
…nathanOppenheimer/convert-reward-manager-test Signed-off-by: Jonathan Oppenheimer <[email protected]>
While this is true, any smart contract that needs to call the precompile needs the Solidity interface, so there must be a source of truth that defines both the precompile and the way it's called. |
Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Austin Larson <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Austin Larson <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Austin Larson <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Austin Larson <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
…enheimer/delete-npm
Following up a few different threads here.
|
|
I have merged @michaelkaplan13's PR into this, and will leave the |
…r/use-new-abi Signed-off-by: Jonathan Oppenheimer <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]>
Why this should be merged
Currently, the committed ABI files are 2 years old, and there is no clear path of how they were generated. This PR deletes those files, and commits the files generated by
compile.goinstead.You can verify that each folders
contract.abifiles matches the newly commited ABI file through the following:You can also compare them directly using json, e.g.
<(git show HEAD:precompile/allowlist/allowlist.abi | jq -S .) <(cat precompile/allowlist/IAllowList.abi | jq -S .) && echo "Files are identical!"There are two exceptions which are commented below:
How this was tested
CI
Need to be documented?
No
Need to update RELEASES.md?
No