test: convert warp npm test to go test #1907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test Signed-off-by: Jonathan Oppenheimer <[email protected]>
…nathanOppenheimer/convert-reward-manager-test Signed-off-by: Jonathan Oppenheimer <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]>
alarso16
reviewed
Dec 9, 2025
Co-authored-by: Austin Larson <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Austin Larson <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Austin Larson <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Austin Larson <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
JonathanOppenheimer
removed
the
DO NOT MERGE
alarso16
approved these changes
Dec 9, 2025
Contributor
alarso16
left a comment
alarso16
left a comment
There was a problem hiding this comment.
I believe that we did choose the abigen approach. In this case, I think this test looks sufficient to check all the necessary behavior
Co-authored-by: Michael Kaplan <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
michaelkaplan13
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This converts the testing present in
contracts/test/warp.tsto go based testing, and removes the hard hat test. The typescript test really wasn't doing much -- just verifying the message and blockchain ID.You can inspect that test to ensure coverage was not lost here:
https://github.com/ava-labs/subnet-evm/blob/master/contracts/test/warp.ts
How this was tested
CI
Need to be documented?
No
Need to update RELEASES.md?
No