ci_build script #65
Draft
ci_build script #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. refactor "clone repositories and build" from `build-with-manifest.yml` and `build-with-manifest-overrides.yml` to `ci_build.sh` 2. run `ci_build.sh` in docker to cache the build and reduce build time by ~50% Signed-off-by: Chizkiyahu Raful <[email protected]>
Signed-off-by: Chizkiyahu Raful <[email protected]>
Signed-off-by: Chizkiyahu Raful <[email protected]>
docker/Dockerfile
Outdated
|
|
||
| ENV MANIFEST_URL=$MANIFEST_URL REPO_DIR=$REPO_DIR INSTALL_DIR=$INSTALL_DIR CHANGED_REPO=$CHANGED_REPO CHANGED_SHA=$CHANGED_SHA | ||
| COPY --chown=$user --chmod=755 ../.github/workflows/scripts/ci_build.sh ./ | ||
| RUN ./ci_build.sh |
There was a problem hiding this comment.
I don't think we should do this. I guess you are trying to cut repo checkout times but I would not do that in the docker image itself. I would like to keep this minimal and just containing dependencies for building
There was a problem hiding this comment.
I removed RUN ./ci_build.sh
Signed-off-by: Chizkiyahu Raful <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-with-manifest.ymlandbuild-with-manifest-overrides.ymltoci_build.shci_build.shin docker to cache the build and reduce build time by ~50%this PR is the sec part of #62\
waiting for