-
Couldn't load subscription status.
- Fork 3
CI cache and linux-arm #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@nlithammer @davidegrohmann I’d love to hear your thoughts on this and get as much feedback as possible on the PR. |
|
Nice work! You are kind of jumping ahead of what we have ongoing 😄 I have a fix coming up for the collect workflow, but it should be independent of this. I like the new build script, it was on my todo list as well. |
|
Hi @chizkiyahu thanks for this PR. Great work! There are many things in here that are of interest for us. |
I think that is kinda expected that you need to fork the manifest repo if you want to run this workflow on your own fork. So I see no problems with that. Have you found any issues with this approach? |
| repo sync -j"$(nproc)" --force-sync "$PROJECT_PATH" | ||
| done | ||
| env: | ||
| REPO_DIR: /home/mlsdkuser/src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These change of folders, is it related to the refactored Dockerfile? I would prefer to keep the sdk folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I push a fix
I am converting this PR to draft and opening new PRs |
1. add running on `ubuntu-24.04-arm`
2. add docker build cache on `ghcr.io` reduce rebuild to < 1 minute
3. docker build add `ci_build.sh` to `repo sync` and build code this reduce the `build-with-manifest.yml` time by >50%
4. weekly rebuild docker without `ghcr.io` cache
5. replace `arm` in `${{ github.repository_owner }}` to allow easy work in fork repos
Signed-off-by: Chizkiyahu Raful <[email protected]>
"/src" -> "/sdk" Signed-off-by: Chizkiyahu Raful <[email protected]>
470eb53 to
7eef272
Compare
ubuntu-24.04-armghcr.ioreduce rebuild to < 1 minuteci_build.shtorepo syncand build code this reduce thebuild-with-manifest.ymltime by >50%ghcr.iocachearmin${{ github.repository_owner }}to allow easy work in fork repostrigger-manifest-build.yml