Closed
Conversation
- isDescriptor(): checks if string is tr(...) format - normalizeToDescriptor(): wraps hex pubkey as tr(pubkey) - extractPubKey(): extracts pubkey from simple descriptor - parseHDDescriptor(): parses HD descriptor components Enables backwards compatibility for legacy hex pubkeys.
Interface for signing with output descriptors, abstracting HD vs static key implementations.
Wraps existing Identity implementations to provide DescriptorProvider interface with static tr(pubkey) descriptors.
- Change DefaultContractParams to use string descriptors instead of Uint8Array - Add normalizeToDescriptor() for backwards compatibility with hex pubkeys - Update serializeParams/deserializeParams for descriptor format - Update test helpers to use valid secp256k1 public keys - All existing tests pass with the new format
- Add walletDescriptor field to PathContext (preferred over walletPubKey) - Mark walletPubKey as @deprecated with migration note - Update resolveRole to use walletDescriptor with fallback to walletPubKey - Handle descriptor-to-pubkey extraction for role matching
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces output descriptors as the storage format for public keys in contract parameters, laying the groundwork for HD wallet support.
Key changes:
isDescriptor,normalizeToDescriptor,extractPubKey,parseHDDescriptor)DescriptorProviderinterface for abstracting HD vs static key implementationsStaticDescriptorProviderclass to wrap legacyIdentityimplementationsDefaultContractHandlerto use string descriptors instead ofUint8Arrayfor pubkeyswalletDescriptorfield toPathContext(deprecatingwalletPubKey)Backwards compatibility:
tr(pubkey)format on readwalletPubKeyfield still works but is marked deprecatedTest plan