Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing in favor of PR #272 (descriptor-contract-params) which contains only the descriptor-related changes. The SeedIdentity HD wallet changes will be submitted in a separate PR. |
6a96dd1 to
5a42a1c
Compare
66d7a7a to
c4fb803
Compare
423e577 to
cf5ab59
Compare
… isOurs, signWithDescriptor, signMessageWithDescriptor)
… of Uint8Array - Change DefaultContractParams.pubKey and serverPubKey from Uint8Array to string (descriptor format) - Add walletDescriptor to PathContext interface (with walletPubKey deprecated) - Update resolveRole() in helpers to check walletDescriptor first, extracting raw pubkeys for comparison - deserializeParams() now normalizes hex pubkeys to descriptors via normalizeToDescriptor() - serializeParams() stores descriptors directly (no hex encoding) - createScript() extracts pubkey bytes from descriptors before passing to DefaultVtxo.Script - Update all test helpers and tests to use valid secp256k1 x-only public keys with descriptor format - Add new test file for descriptor-specific serialize/deserialize/round-trip tests - Preserve DelegateContractHandler and VHTLC tests unchanged
b029904 to
832797f
Compare
…itcoin-descriptors library Use defaultFactory.expand() from @kukks/bitcoin-descriptors instead of hand-rolled regex patterns for extractPubKey and parseHDDescriptor. Updated tests to use real descriptors generated from the test mnemonic.
Summary
Test plan