Skip to content

fix(margin): Fixing margin issues #36479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geido merged 3 commits into from
Dec 22, 2025
+4 −10
Merged

fix(margin): Fixing margin issues #36479

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
551f99e
fix(margin): fixing margin issues
alexandrusoare Dec 9, 2025
bc7cd09
cast git add .
alexandrusoare Dec 12, 2025
6b1ff08
add the space back between the checkboxes
alexandrusoare Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions superset-frontend/src/features/databases/DatabaseModal/ExtraOptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,9 +469,7 @@ const ExtraOptions = ({
),
children: (
<>
<StyledInputContainer
css={!isFileUploadSupportedByEngine ? no_margin_bottom : {}}
>
<StyledInputContainer>
<div className="input-container">
<Checkbox
id="per_user_caching"
Expand All @@ -490,9 +488,7 @@ const ExtraOptions = ({
/>
</div>
</StyledInputContainer>
<StyledInputContainer
css={!isFileUploadSupportedByEngine ? no_margin_bottom : {}}
>
<StyledInputContainer>
<div className="input-container">
<Checkbox
id="impersonate_user"
Expand All @@ -517,9 +513,7 @@ const ExtraOptions = ({
</div>
</StyledInputContainer>
{isFileUploadSupportedByEngine && (
<StyledInputContainer
css={!db?.allow_file_upload ? no_margin_bottom : {}}
>
<StyledInputContainer>
<div className="input-container">
<Checkbox
id="allow_file_upload"
Expand All @@ -534,7 +528,7 @@ const ExtraOptions = ({
</StyledInputContainer>
)}
{isFileUploadSupportedByEngine && !!db?.allow_file_upload && (
<StyledInputContainer css={no_margin_bottom}>
<StyledInputContainer className="extra-container">
<div className="control-label">
{t('Schemas allowed for File upload')}
</div>
Expand Down
Loading