fix(margin): Fixing margin issues

[alexandrusoare]

User description

SUMMARY

Security section checkboxes are to close to the secure extra field

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

AFTER

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

---

CodeAnt-AI Description

Fix spacing between Security options and file-upload fields in Database modal

What Changed

• Security section input block always uses the no-bottom-margin spacing so checkboxes no longer appear too close to the following extra fields
• The spacing logic for the impersonate and file-upload blocks was corrected so margins are applied when the engine supports file uploads and when file uploads are enabled
• When the "Schemas allowed for File upload" field appears, it uses a dedicated container class to avoid collapsed spacing with adjacent controls

Impact

✅ Clearer form spacing in Database modal
✅ Fewer layout overlaps between security checkboxes and extra fields
✅ Consistent spacing when toggling file upload options

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

[codeant-ai-for-open-source]

CodeAnt AI is reviewing your PR.

[codeant-ai-for-open-source]

Nitpicks 🔍

🔒 No security issues identified

⚡ Recommended areas for review Conditional CSS logic Several StyledInputContainer usages changed their conditional css expressions (inverted conditions). Verify the intended spacing rules across combinations of isFileUploadSupportedByEngine and db?.allow_file_upload. Confirm these conditions do not unintentionally collapse margins or leave empty style objects being passed to the css prop. New className added A new className="extra-container" was added for the schemas upload block to avoid collapsed spacing. Ensure the CSS for extra-container exists in the corresponding styles (or prefer a styled-prop). If the class is missing this will have no effect.

[codeant-ai-for-open-source]

CodeAnt AI finished reviewing your PR.

[github-actions]

🎪 Showtime is building environment on GHA for db250b9

[github-actions]

🎪 Showtime deployed environment on GHA for db250b9

• Environment: http://54.202.195.44:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

[github-actions]

🎪 Showtime is building environment on GHA for bc7cd09

[github-actions]

🎪 Showtime deployed environment on GHA for bc7cd09

• Environment: http://35.87.199.198:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

[geido]

@alexandrusoare I think the PR introduces some inconsistency with the checkboxes. In this PR they look pretty close to each other. Before, they looked like they had more space, and across different sections, they now also look inconsistent.

[codeant-ai-for-open-source]

CodeAnt AI is running Incremental review

[alexandrusoare]

@alexandrusoare I think the PR introduces some inconsistency with the checkboxes. In this PR they look pretty close to each other. Before, they looked like they had more space, and across different sections, they now also look inconsistent.

I thought that removing the space looked better, but you are right that it should respect the current pattern, and the current pattern is that there is more space between the checkboxes