Skip to content

MINOR: Ensure proper visibility of attribute accesses across threads #21014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dajac merged 1 commit into from
Nov 28, 2025
Merged

MINOR: Ensure proper visibility of attribute accesses across threads #21014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@ class CoordinatorContext {
/**
* The current state.
*/
CoordinatorState state;
volatile CoordinatorState state;

/**
* The current epoch of the coordinator. This represents
Expand Down
2 changes: 1 addition & 1 deletion ...coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ public GroupCoordinatorService build() {
* The metadata image to extract topic id to names map.
* This is initialised when the {@link GroupCoordinator#onNewMetadataImage(CoordinatorMetadataImage, CoordinatorMetadataDelta)} is called
*/
private CoordinatorMetadataImage metadataImage = null;
private volatile CoordinatorMetadataImage metadataImage = null;
Copy link
Member

@chia7712 chia7712 Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume those changes are bug fixes, and the 4.1 branch may have a next release.

Copy link
Member

@chia7712 chia7712 Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems trunk is missing this fix. @majialong could you file a minor patch for trunk?

Copy link
Contributor

@majialoong majialoong Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open #21021 for this.

Copy link
Member Author

@dajac dajac Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trunk is covered by #21008.


/**
*
Expand Down