MINOR: Ensure proper visibility of attribute accesses across threads #21014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Nov 28, 2025
| * This is initialised when the {@link GroupCoordinator#onNewMetadataImage(CoordinatorMetadataImage, CoordinatorMetadataDelta)} is called | ||
| */ | ||
| private CoordinatorMetadataImage metadataImage = null; | ||
| private volatile CoordinatorMetadataImage metadataImage = null; |
Member
There was a problem hiding this comment.
I assume those changes are bug fixes, and the 4.1 branch may have a next release.
Member
There was a problem hiding this comment.
It seems trunk is missing this fix. @majialong could you file a minor patch for trunk?
Member
|
open #21020 for the backport |
chia7712
pushed a commit
that referenced
this pull request
Nov 29, 2025
…21020) backport #21014 Reviewers: Chia-Ping Tsai <[email protected]>
Member
Author
|
Sorry guys. I wanted to follow-up on this on Monday (due to the weekend). You got there before I could. Thanks! |
chia7712
pushed a commit
that referenced
this pull request
Dec 1, 2025
…21023) backport #21014. In 4.0, `MetadataImage` has not yet been introduced into `GroupCoordinatorService`. Therefore, this patch only includes changes to `CoordinatorRuntime`. Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found those two cases while working in this area. In both cases, they
are read by multiple threads so they must either be volatile or
acquiring the appropriate lock. Using volatile is fine here.
Reviewers: Lianet Magrans [email protected]