Skip to content

escape connection type and field name in registry connection builder #71700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Samin061 wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −8
Open

escape connection type and field name in registry connection builder #71700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions registry/src/js/connection-builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,11 @@

function renderConnectionForm(container, connType, data) {
var connIdDefault = connType.replace(/[^a-zA-Z0-9]/g, "_");
var safeConnType = escapeAttr(connType);
var html = '<div class="conn-field">';
html += '<label for="conn-id-' + connType + '">Connection ID</label>';
html += '<label for="conn-id-' + safeConnType + '">Connection ID</label>';
html +=
'<input type="text" id="conn-id-' + connType +
'<input type="text" id="conn-id-' + safeConnType +
'" data-field="conn_id" value="' + escapeAttr(connIdDefault) +
'" placeholder="my_conn_id">';
html += "</div>";
Expand Down Expand Up @@ -194,18 +195,20 @@
function renderField(connType, key, field, isCustom) {
var label = field.label || key;
var id = "conn-" + connType + "-" + key;
var safeId = escapeAttr(id);
var safeKey = escapeAttr(key);
var isSensitive =
key === "password" || field.is_sensitive || field.format === "password";
var fieldType = field.type || "string";
var html = '<div class="conn-field">';
html += '<label for="' + id + '">' + escapeHTML(label);
html += '<label for="' + safeId + '">' + escapeHTML(label);
if (isSensitive) {
html += ' <span class="field-sensitive">sensitive</span>';
}
html += "</label>";

if (field.enum && field.enum.length) {
html += '<select id="' + id + '" data-field="' + key + '"';
html += '<select id="' + safeId + '" data-field="' + safeKey + '"';
if (isCustom) html += ' data-custom="true"';
html += ">";
html += '<option value="">-- Select --</option>';
Expand All @@ -216,25 +219,25 @@
html += "</select>";
} else if (fieldType === "boolean") {
var checked = field.default === true || field.default === "true" ? " checked" : "";
html += '<label class="conn-checkbox"><input type="checkbox" id="' + id + '" data-field="' + key + '"';
html += '<label class="conn-checkbox"><input type="checkbox" id="' + safeId + '" data-field="' + safeKey + '"';
if (isCustom) html += ' data-custom="true"';
html += ' data-type="boolean"' + checked + ">";
html += " " + escapeHTML(label) + "</label>";
} else if (key === "extra" || fieldType === "object") {
html += '<textarea id="' + id + '" data-field="' + key + '" rows="3"';
html += '<textarea id="' + safeId + '" data-field="' + safeKey + '" rows="3"';
if (isCustom) html += ' data-custom="true"';
if (field.placeholder) html += ' placeholder="' + escapeAttr(field.placeholder) + '"';
html += "></textarea>";
} else if (fieldType === "integer" || fieldType === "number") {
html += '<input type="number" id="' + id + '" data-field="' + key + '"';
html += '<input type="number" id="' + safeId + '" data-field="' + safeKey + '"';
if (isCustom) html += ' data-custom="true"';
if (field.default != null) html += ' value="' + escapeAttr(String(field.default)) + '"';
if (field.minimum != null) html += ' min="' + escapeAttr(String(field.minimum)) + '"';
if (field.placeholder) html += ' placeholder="' + escapeAttr(field.placeholder) + '"';
html += ">";
} else {
var inputType = isSensitive ? "password" : "text";
html += '<input type="' + inputType + '" id="' + id + '" data-field="' + key + '"';
html += '<input type="' + inputType + '" id="' + safeId + '" data-field="' + safeKey + '"';
if (isCustom) html += ' data-custom="true"';
if (field.default != null && fieldType !== "boolean") html += ' value="' + escapeAttr(String(field.default)) + '"';
if (field.placeholder) html += ' placeholder="' + escapeAttr(field.placeholder) + '"';
Expand Down