escape connection type and field name in registry connection builder - #71700
Open
Samin061 wants to merge 1 commit into
Open
escape connection type and field name in registry connection builder#71700Samin061 wants to merge 1 commit into
Samin061 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
renderField and renderConnectionForm build the connection form HTML by concatenating the connection type and each widget field name into the id, for and data-field attributes without escaping, while the surrounding label, placeholder and description already pass through escapeHTML/escapeAttr. A connection form widget whose field name or connection type carries a double quote and angle brackets breaks out of the attribute and injects markup into the registry page when its chip is opened. Both values now go through escapeAttr, matching the escaping applied to the neighbouring fields and to the search results in #71618.
Was generative AI tooling used to co-author this PR?