Escape icon insertion in registry search results template - #71618
Merged
Conversation
Lee-W
force-pushed
the
fix-registry-search-icon-escape
branch
from
August 14, 2026 13:55
528b5a8 to
5a73232
Compare
GitHub code-scanning alert #621 (CodeQL js/xss-through-dom) flags resultsContainer.innerHTML = html at this file's line 131 as a sink for typesEl.textContent, read at line 33 and parsed into the typeLabels/typeIcons maps. The typeLabels branch of that data was already passed through escapeHtml() before reaching the sink; the typeIcons branch (surfaced here as the icon variable) was not, making icon the actual unescaped leg of the flagged flow. potiuk dismissed the alert as a false positive because typesEl.textContent is build-time-generated JSON, not user input, so neither branch is exploitable today. This closes the last unescaped leg of that flow, matching the escaping already applied to every other interpolated field in the same template.
Lee-W
force-pushed
the
fix-registry-search-icon-escape
branch
from
August 14, 2026 13:56
5a73232 to
4e8abe7
Compare
uros-b
approved these changes
Aug 15, 2026
Member
|
LGTM |
Lee-W
marked this pull request as ready for review
August 16, 2026 02:49
uranusjr
approved these changes
Aug 17, 2026
amoghrajesh
approved these changes
Aug 17, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The other interpolated fields in the search-result template (url, resultType, name, moduleType, providerName, description) were already passed through escapeHtml(); icon was the one exception. It currently only ever holds trusted build-time values ('P', 'M', or an entry from types.json), so this is a defense-in-depth fix rather than a fix for an exploitable bug — GitHub code-scanning alert #621 covering this file was already dismissed as a false positive for that reason.
Was generative AI tooling used to co-author this PR?
Generated-by: [Claude] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.