feat: add new Doctype Bulk Leave Application (DRC-148)#8
feat: add new Doctype Bulk Leave Application (DRC-148)#8MarcCon wants to merge 18 commits intoversion-15from
Conversation
time_capture/time_capture/doctype/bulk_leave_application/bulk_leave_application.json
Show resolved
Hide resolved
time_capture/time_capture/doctype/bulk_leave_application/bulk_leave_application.json
Outdated
Show resolved
Hide resolved
time_capture/time_capture/doctype/bulk_leave_application/bulk_leave_application.json
Outdated
Show resolved
Hide resolved
time_capture/time_capture/doctype/bulk_leave_application/bulk_leave_application.json
Outdated
Show resolved
Hide resolved
time_capture/time_capture/doctype/bulk_leave_application/bulk_leave_application.json
Show resolved
Hide resolved
...e_capture/doctype/bulk_leave_application_dates_table/bulk_leave_application_dates_table.json
Show resolved
Hide resolved
...e_capture/doctype/bulk_leave_application_dates_table/bulk_leave_application_dates_table.json
Outdated
Show resolved
Hide resolved
|
This comments the changes that I added on top of Marc's contributions. ChangesSmall Changes
Medium Changes
Big Changescreate Attendances instead of Leave Applications: a918ad1 Use Cases to cover:
To use case 4):This is a very likely use case. Example: Weekly off for someone who effectively works a four day work-week. When this person goes on vacation, she will apply for, let's say 2 weeks, vacation. Problem: This kind of Leave Application could not be inserted Solution: Follow Up Problem: No Leave Ledgers are createdEmployee's leave balance is unchanged
Follow Up Problem: "Urlaub" Leave Application updates the existing Attendance with an an un-distinctive hookIt is important, that we recognize the change in Leave Type to calculate the Flexitime etc. doc.db_set is used. That can only be recognized via on_change hook. doc.has_value_changed also does not work as needed in that case. Follow Up Problem: -> Solution: We accept that... b) Un-related update of the Attendance: Example: The Attendance is updated a year later, let's say because a custom color field was added and this is set for all existing Attendances via patch. That re-calculates the Flexitime etc. This can lead to wrong data because the Expected Daily Working Time is float field in Employee, which can change if an Employee's contract changed. Now, the 1 year old Attendance is re-calculated with the current Expected Daily Working Time.
Todo
Todo after Review/Test:
|
This PR introduces a new Bulk Leave Application DocType to simplify the creation of multiple Leave Applications.
Features: