Skip to content

Propagate suite-level CLI overrides to constituent task specs #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
finbarrtimbers wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Propagate suite-level CLI overrides to constituent task specs #180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2663b2e
Propagate suite-level CLI overrides to constituent task specs Co-Auth…
finbarrtimbers May 15, 2026
db36712
Preserve priority suffix when propagating suite overrides Co-Authored…
finbarrtimbers May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions src/olmo_eval/cli/run/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

from rich.console import Console

from olmo_eval.evals.suites import get_suite, suite_exists
from olmo_eval.harness.config import HarnessConfig, ProviderConfig

console = Console()
Expand Down Expand Up @@ -331,14 +332,31 @@ def build(self) -> RunConfig:
Returns:
RunConfig with parsed and validated settings.
"""
# Build task specs and overrides from CLI -o flags
# Build task specs and overrides from CLI -o flags. Suite-level overrides
# are propagated to each constituent task spec.
task_specs: list[str] = list(self.task)
task_overrides: dict[str, dict[str, Any]] = {}
resolved_cli_overrides: dict[str, list[str]] = {}
for task_spec, cli_overrides in self.cli_task_overrides.items():
if cli_overrides:
override_dict: dict[str, Any] = {}
_apply_dotlist_overrides(override_dict, cli_overrides)
task_overrides[task_spec] = override_dict
if not cli_overrides:
continue
if "@" in task_spec:
base_spec, priority = task_spec.rsplit("@", 1)
priority_suffix = f"@{priority}"
else:
base_spec = task_spec
priority_suffix = ""
if suite_exists(base_spec):
for child_spec in get_suite(base_spec).expand():
key = f"{child_spec}{priority_suffix}"
resolved_cli_overrides.setdefault(key, []).extend(cli_overrides)
else:
resolved_cli_overrides.setdefault(task_spec, []).extend(cli_overrides)

task_overrides: dict[str, dict[str, Any]] = {}
for task_spec, cli_overrides in resolved_cli_overrides.items():
override_dict: dict[str, Any] = {}
_apply_dotlist_overrides(override_dict, cli_overrides)
task_overrides[task_spec] = override_dict

# Resolve harness configuration with provider config built in
harness_config = self._resolve_harness_config(self.model)
Expand Down
Loading