Propagate suite-level CLI overrides to constituent task specs#180
Propagate suite-level CLI overrides to constituent task specs#180finbarrtimbers wants to merge 2 commits into
Conversation
…ored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2663b2e296
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for child_spec in get_suite(base_spec).expand(): | ||
| resolved_cli_overrides.setdefault(child_spec, []).extend(cli_overrides) |
There was a problem hiding this comment.
Preserve priority suffix when propagating suite overrides
When a suite is invoked with a priority suffix, e.g. -t suite@high -o max_tokens=..., expand_tasks() later runs the children as child@high and _build_task_overrides() looks up overrides by that exact spec. This propagation stores the override under the bare child_spec, so the suite-level override is still silently dropped for prioritized suites; append the original priority suffix to each child override key to match the expanded run specs.
Useful? React with 👍 / 👎.
…-By: Claude Opus 4.7 <noreply@anthropic.com>
Summary
-oCLI override targets a suite name, expand the suite and apply the override to every constituent task spec instead of dropping it.Example of the bug
Before this fix, the override is keyed by
aime_2022_to_2025but the runner only sees the expanded constituent specs (aime_2022:pass_at_32,aime_2023:pass_at_32,aime_2024:pass_at_32,aime_2025:pass_at_32), so themax_tokens=16384override is silently dropped and each task runs with its defaultmax_tokens. After the fix, the override is propagated to each child spec.Test plan
aime_2022_to_2025 -o sampling_params.max_tokens=16384) and confirm each constituent task receives the override.🤖 Generated with Claude Code