Skip to content

fix: show script exception text instead of empty message #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jhoan0714 wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −2
Open

fix: show script exception text instead of empty message #222

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1d4584
fix: show script exception text instead of empty message
Jhoan0714 Jul 9, 2026
d2588c9
Merge branch 'main' into fix/eval-empty-script-exception
hugs Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions clicker/internal/bidi/script.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,16 @@ func (c *Client) Evaluate(context, expression string) (interface{}, error) {
var evalResult struct {
Type string `json:"type"`
Result json.RawMessage `json:"result"`
ExceptionDetails struct {
Text string `json:"text"`
} `json:"exceptionDetails"`
}
if err := json.Unmarshal(msg.Result, &evalResult); err != nil {
return nil, fmt.Errorf("failed to parse script.evaluate result: %w", err)
}

if evalResult.Type == "exception" {
return nil, fmt.Errorf("script exception: %s", string(evalResult.Result))
return nil, fmt.Errorf("script exception: %s", evalResult.ExceptionDetails.Text)
}

// Parse the remote value
Expand Down Expand Up @@ -137,13 +140,16 @@ func (c *Client) CallFunction(context, functionDeclaration string, args []interf
var callResult struct {
Type string `json:"type"`
Result json.RawMessage `json:"result"`
ExceptionDetails struct {
Text string `json:"text"`
} `json:"exceptionDetails"`
}
if err := json.Unmarshal(msg.Result, &callResult); err != nil {
return nil, fmt.Errorf("failed to parse script.callFunction result: %w", err)
}

if callResult.Type == "exception" {
return nil, fmt.Errorf("script exception: %s", string(callResult.Result))
return nil, fmt.Errorf("script exception: %s", callResult.ExceptionDetails.Text)
}

// Parse the remote value
Expand Down
Loading