fix: show script exception text instead of empty message#222
Open
Jhoan0714 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #221 — when
vibium evalor MCPbrowser_evaluateruns JavaScript that throws, the CLI previously reported an empty error:The browser did throw a real exception, but
bidi.Clientread the wrong field from the WebDriver BiDi response. This change parsesexceptionDetails.textso users see the actual JavaScript error message.Why this matters
vibium evaldebuggable when scripts fail (wrong variable,SecurityErroronlocalStorage, etc.)browser_evaluateand any path usingCallFunction()through the BiDi clientparseScriptResult()(clicker/internal/api/helpers.go), which already readsexceptionDetailsValidation
Before fix:
After fix:
Note: rebuild and restart the daemon (
vibium daemon stop && vibium daemon start) to load the new binary.