Skip to content

Use AOI bounds for FCF clip_box (fix WindowError on some non-CONUS AOIs) #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZachHoppinen wants to merge 1 commit into from
Closed

Use AOI bounds for FCF clip_box (fix WindowError on some non-CONUS AOIs) #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions spicy_snow/processing/generate_dataarrays.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# faster reprojection utils
import rasterio
import rioxarray
from rasterio.warp import reproject, Resampling, transform_bounds
from rasterio.warp import reproject, Resampling
from rasterio.enums import Resampling as Rsmp
from rasterio.transform import rowcol

Expand Down Expand Up @@ -343,16 +343,13 @@ def generate_forest_fraction_dataarray(aoi, ref = None) -> xr.Dataset:
# clip to the target area BEFORE any computation, otherwise the
# full raster gets loaded into memory and the process is killed.
fcf = rioxarray.open_rasterio(fcf_path).squeeze(drop=True)
# Build the clip box in EPSG:4326 (FCF native CRS). Prefer the
# reprojection target's bounds when available for the tightest crop;
# fall back to the AOI bounds.
if ref is not None:
xmin, ymin, xmax, ymax = transform_bounds(
ref.rio.crs, "EPSG:4326", *ref.rio.bounds()
)
else:
xmin, ymin, xmax, ymax = aoi.bounds
# Clip in EPSG:4326 (FCF native CRS) using AOI bounds. The ref grid
# is also in EPSG:4326 and clipped to aoi.bounds in
# generate_reference_grid, so using ref.rio.bounds() here was
# equivalent but vulnerable to pixel-edge / projection round-trip
# quirks that produced degenerate windows on some AOIs.
# Small halo so reproject_match has neighboring pixels available.
xmin, ymin, xmax, ymax = aoi.bounds
buf = 0.05 # ~5 km in degrees
fcf = fcf.rio.clip_box(
minx=xmin - buf, miny=ymin - buf, maxx=xmax + buf, maxy=ymax + buf
Expand Down
Loading