Use AOI bounds for FCF clip_box (fix WindowError on some non-CONUS AOIs)#84
Closed
ZachHoppinen wants to merge 1 commit into
Closed
Use AOI bounds for FCF clip_box (fix WindowError on some non-CONUS AOIs)#84ZachHoppinen wants to merge 1 commit into
ZachHoppinen wants to merge 1 commit into
Conversation
The ref-based clip_box bounds in generate_forest_fraction_dataarray
were failing on some non-CONUS AOIs (white_mtns 2024_2025) with:
rasterio.errors.WindowError: Bounds and transform are inconsistent
Investigation: generate_reference_grid already reprojects ref to
EPSG:4326 and clips to aoi.bounds, so ref.rio.bounds() was effectively
the same as aoi.bounds anyway. The "tighter crop" optimization gave
zero practical benefit but introduced a bug surface where pixel-edge
snapping or projection round-trip quirks could produce a degenerate
window on the FCF raster.
Drop the if-ref branch, always use aoi.bounds + 0.05 deg halo.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code