-
Notifications
You must be signed in to change notification settings - Fork 0
[Do Not Merge] First sketch of tess_asteroids
#1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christinahedges
wants to merge
1
commit into
main
Choose a base branch
from
christina
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| __version__ = '0.1.0' | ||
| __version__ = "0.1.0" | ||
|
|
||
| from .asteroid import Asteroid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| """Class to obtain, correct and analyze TESS asteroid data""" | ||
| import lightkurve as lk | ||
|
|
||
| import tess_ephem | ||
| import tess_locator | ||
| import tess_cloud | ||
| import tess_backdrop | ||
|
|
||
|
|
||
| class Asteroid(lk.TargetPixelFile): | ||
| """Class to work with TESS asteroid data""" | ||
|
|
||
| def __init__(self, asteroid_name): | ||
| self.asteroid_name = asteroid_name | ||
| self._correct_sky_background() | ||
| self._correct_star_background() | ||
|
|
||
| @static_method | ||
| def from_MAST(self, asteroid_name): | ||
| """Get object out of tesscut dataset""" | ||
| self.asteroid_name = asteroid_name | ||
| self._get_data() | ||
| self.__init__(**kwargs) | ||
|
|
||
| def _get_data(self): | ||
| """Use tess_locator, tess_cloud""" | ||
| raise NotImplementedError | ||
|
|
||
| def _correct_sky_background(self): | ||
| """Use tess_backdrop to correct scattered light""" | ||
| raise NotImplementedError | ||
|
|
||
| def _correct_star_background(self): | ||
| """Use tess_backdrop, and new functionality, to remove stars from background""" | ||
| raise NotImplementedError | ||
|
|
||
| def create_aperture(self): | ||
| """create_threshold_mask may work just as well here, but we might want to think about | ||
| special functions""" | ||
| raise NotImplementedError | ||
|
|
||
| def to_lightcurve(self): | ||
| """makes special lk.LightCurve class?""" | ||
| raise NotImplementedError | ||
|
|
||
|
|
||
| class AsteroidLightCurve(lk.LightCurve): | ||
| """I think we might need a special lk class...but maybe not?""" | ||
|
|
||
| def get_MPC_data(self): | ||
| # Get supplmental data from MPC? | ||
| raise NotImplementedError | ||
|
|
||
| def to_periodogram(self, type="GP"): | ||
| """Special periodogram that uses GP kernels to estimate period?""" | ||
| raise NotImplementedError | ||
|
|
||
| def to_file(self): | ||
| """Some sort of MPC viable file with relevant meta info...""" | ||
| raise NotImplementedError | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| """Tools to calculate periodicities in asteroid light curves?""" | ||
| import lightkurve as lk | ||
|
|
||
|
|
||
| class GPPeriodogram(lk.Periodogram): | ||
| """A periodogram that works based on SHO GP kernels to obtain | ||
| a distribution of consistent periods.""" | ||
|
|
||
| def __init__(self, **kwargs): | ||
| """Initialize a normal periodogram...""" | ||
| super.__init__(**kwargs) | ||
|
|
||
|
|
||
| class AugmentedBLSPeriodogram(lk.Periodogram): | ||
| """A periodogram that fits a BLS and SHO at the same time, to model binary asteroids.""" | ||
|
|
||
| def __init__(self, **kwargs): | ||
| """Initialize a normal periodogram...""" | ||
| super.__init__(**kwargs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,16 @@ | ||
| from tess_asteroids import __version__ | ||
| import pytest | ||
| from tess_asteroid import Asteroid | ||
|
|
||
|
|
||
| def test_version(): | ||
| assert __version__ == '0.1.0' | ||
| assert __version__ == "0.1.0" | ||
|
|
||
|
|
||
| @pytest.mark.remote_data | ||
| def test_asteroid(): | ||
| tpf = Asteroid.from_MAST("Juno") | ||
| lc = tpf.to_lightcurve() | ||
| per = lc.to_periodogram("GP", minimum_period=0.1, maximum_period=10) | ||
| assert (per.period_at_max_power[0].value, 10) | ||
| assert (per.period_at_max_power[1].value, 0.1) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider naming it
MinorPlanetto avoid confusion if we measure non-asteroid moving objects?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! Names are important, sounds great! We can totally rename the package too