[Do Not Merge] First sketch of tess_asteroids
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barentsen
reviewed
Jun 3, 2021
| import tess_backdrop | ||
|
|
||
|
|
||
| class Asteroid(lk.TargetPixelFile): |
There was a problem hiding this comment.
We should consider naming it MinorPlanet to avoid confusion if we measure non-asteroid moving objects?
There was a problem hiding this comment.
Yeah! Names are important, sounds great! We can totally rename the package too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@barentsen and I have been chatting about the sort of tool we might need to bring all the packages together, and enable
lightkurvestyle (TargetPixelFileandLightCurvetype objects)