Skip to content

Reset missing date information in CanValidateDateTime #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: 2.4
Choose a base branch
from
Open

Reset missing date information in CanValidateDateTime #1551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0718e6d
Reset missing date information in CanValidateDateTime
davidespagnoli Oct 31, 2025
d2c912a
Fix string quotes in date format validation
davidespagnoli Oct 31, 2025
13cfd4e
space to improve readability
davidespagnoli Oct 31, 2025
ee3e365
Enhance date validation tests with timecop
davidespagnoli Nov 3, 2025
8559275
fix test
davidespagnoli Nov 3, 2025
936af65
fix data provider
davidespagnoli Nov 3, 2025
5b25f47
fix blank lines
davidespagnoli Nov 3, 2025
c8dbb3b
Refactor dateTime validation test for overflow days
davidespagnoli Nov 3, 2025
c364592
Update comment in CanValidateDateTimeTest
davidespagnoli Nov 3, 2025
6dbea11
typo
davidespagnoli Nov 3, 2025
407da29
Add 'timecop' extension to CI workflow
davidespagnoli Nov 4, 2025
ab768a6
Add time freezing for date validation test
davidespagnoli Nov 4, 2025
19dfa29
Update PHP extensions in CI configuration
davidespagnoli Nov 4, 2025
2e9c33c
Update CI workflow to remove timecop-beta extension
davidespagnoli Nov 4, 2025
f6d8b8a
Update CanValidateDateTimeTest.php
davidespagnoli Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/Helpers/CanValidateDateTime.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ private function isDateTime(string $format, string $value): bool

if ($this->isDateFormat($format)) {
$formattedDate = DateTime::createFromFormat(
$format,
'!' . $format,
$value,
new DateTimeZone(date_default_timezone_get())
);
Expand Down
10 changes: 10 additions & 0 deletions tests/unit/Helpers/CanValidateDateTimeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,16 @@ public function shouldFindWhenValueIsNotDateTime(string $format, string $value):
self::assertFalse($this->isDateTime($format, $value));
}

/**
* @test isDateTime for month, when in "overflow" days (i.e. '2' when I run the test on 31st of any month)
* if PECL timecop was installed we could have used "timecop_freeze(new DateTime('2025-10-31 12:00:00'));" before the assertion and "timecop_return();" after.
* without PECL timecop this test checks the fixed bug only on 29th, 30th and 31st of every month.
*/
public function shouldFindWhenValueIsDateTimeOnOverflowDay(): void
{
self::assertTrue($this->isDateTime('m-Y', '02-2025'));
}

/**
* @return mixed[][]
*/
Expand Down