Reset missing date information in CanValidateDateTime #1551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missing date information are now reset to 0 (1970-01-01T00:00:00), because otherwise they are taken from current date/time, so:
Respect\Validation\Validator::date("m")->isValid('06')
is not valid on 31st of every month
Refactor date validation tests to include time freezing.
Updated the test for date validation to check overflow days without using timecop.
Fix comment formatting for clarity in test case.
Use timecop to freeze time for date validation tests.
Removed 'timecop-beta' extension from PHP setup in CI workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missing date information are now reset to 0 (1970-01-01T00:00:00), because otherwise they are taken from current date/time (please refer to https://www.php.net/manual/en/datetimeimmutable.createfromformat.php), so:
Respect\Validation\Validator::date("m")->isValid('06')
is valid if it's run on October 30
is not valid if it's run on October, 31