-
Notifications
You must be signed in to change notification settings - Fork 12
[Core] Fix compilation with module #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Luohaothu
wants to merge
18
commits into
master
Choose a base branch
from
fix-module
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+713
−411
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
cb48783
[Ext] Suppress Clang C2y warnings in Google Benchmark
Luohaothu 88cb99c
[CI] Fix CMake install prefix and import-std logic
Luohaothu cf01956
[CI] Unify usage requirements scope
Luohaothu c36f2de
[CI] Fix OpenMP includes for Clang+libgomp
Luohaothu a3cf163
[Core] Remove invalid .template keywords and fix constraints
Luohaothu 04190ad
[Core] Improve module header hygiene
Luohaothu 1bcb2c8
[Core] Add guarding macro for module
Luohaothu c02d590
[CI] Code auto formatted
01f95de
[CI] Fix build
Luohaothu 463a5da
[Core] Include Google Benchmark when OPFLOW_BUILD_ALL=ON
Luohaothu 0728ea5
[CI] Build GCC 14 instead of gcc-trunk for stable modules support
Luohaothu d5abdb2
[CI] Use GCC 14 from Ubuntu 24.04 instead of building from source
Luohaothu 756e9a5
[CI] Use ubuntu:24.04 with GCC 14 instead of gcc-trunk container
Luohaothu 6a07b01
[CI] Install newer git from PPA in ubuntu:24.04
Luohaothu 179f9a5
[CI] Fix git install order - install before checkout
Luohaothu 200f11d
[CI] Use explicit bash shell and fix RUNNER_OS check
Luohaothu c167c12
[CI] Remove unnecessary RUNNER_OS checks
Luohaothu f476314
[CI] Use gcc:14 official image with required tools
Luohaothu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
OPFLOW_BUILD_ALLis ON butOPFLOW_BUILD_BENCHMARKSis OFF (the default), this block still adds the benchmarks, but Google Benchmark is now only added inexternal/CMakeLists.txtunderif(OPFLOW_BUILD_BENCHMARKS). In that configurationbenchmark::benchmarkis never defined, sobenchmark/CMakeLists.txtfails to configure/link. Consider extending the external benchmark condition to includeOPFLOW_BUILD_ALLor re-adding the subdirectory here.Useful? React with 👍 / 👎.