[Core] Fix compilation with module #83
Conversation
|
Important Review skippedToo many files! This PR contains 218 files, which is 68 over the limit of 150. You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c02d590214
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| set(BENCHMARK_ENABLE_INSTALL OFF) | ||
| set(BENCHMARK_ENABLE_TESTING OFF) | ||
| set(BENCHMARK_ENABLE_GTEST_TESTS OFF) | ||
| add_subdirectory(${CMAKE_CURRENT_LIST_DIR}/external/benchmark EXCLUDE_FROM_ALL) | ||
| add_subdirectory(benchmark) |
There was a problem hiding this comment.
When OPFLOW_BUILD_ALL is ON but OPFLOW_BUILD_BENCHMARKS is OFF (the default), this block still adds the benchmarks, but Google Benchmark is now only added in external/CMakeLists.txt under if(OPFLOW_BUILD_BENCHMARKS). In that configuration benchmark::benchmark is never defined, so benchmark/CMakeLists.txt fails to configure/link. Consider extending the external benchmark condition to include OPFLOW_BUILD_ALL or re-adding the subdirectory here.
Useful? React with 👍 / 👎.
No description provided.