fixed race condition causing lslib to attempt installation twice in quick succession#21929
Merged
fixed race condition causing lslib to attempt installation twice in quick succession#21929
Conversation
also consolidated how we build the fileList for the installer, and added instruction sanity check to block copy instructions from being used with directories fixes https://linear.app/nexus-mods/issue/APP-98/bg3-lslib-installer-fails-on-folder-entries
IDCs
changed the title
Aragas
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two concurrent installers were fighting over the extracted files, potentially generating a corrupt copy in staging folder.
also consolidated how we build the fileList for the installer, and added instruction sanity check to block copy instructions from being used with directories
Because it's a race condition, it's extremely intermittent and there's no reliable way to reproduce this.
Only way you can test this is to leave a breakpoint in the lslib installer and make sure it only runs once when downloading through the lslib requirement dialog which pops up whenever lslib is missing from the user's mod setup.
fixes https://linear.app/nexus-mods/issue/APP-98/bg3-lslib-installer-fails-on-folder-entries