Skip to content

patch get_bars_ticks() #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
malcolmsailor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

patch get_bars_ticks() #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/miditok/utils/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,7 +710,11 @@ def get_bars_ticks(score: Score, only_notes_onsets: bool = False) -> list[int]:
# Mock the last one to cover the last section in the loop below in all cases, as it
# prevents the case in which the last time signature had an invalid numerator or
# denominator (that would have been skipped in the while loop below).
time_sigs.append(TimeSignature(max_tick, *TIME_SIGNATURE))

# When only_notes_onsets is True, we add an extra tick because otherwise, when
# the last onset coincides with a start of a bar, it will be excluded because
# range() is exclusive of the endpoint.
time_sigs.append(TimeSignature(max_tick + int(only_notes_onsets), *TIME_SIGNATURE))

# Section from tick 0 to first time sig is 4/4 if first time sig time is not 0
if (
Expand Down
Loading